From: John Daley <johndale@cisco.com>
To: dev@dpdk.org
Cc: bruce.richarsdon@intel.com, John Daley <johndale@cisco.com>
Subject: [dpdk-dev] [PATCH v3 13/13] enic: fix Tx IP and UDP/TCP checksum offload
Date: Thu, 2 Jun 2016 17:22:57 -0700 [thread overview]
Message-ID: <1464913377-30879-14-git-send-email-johndale@cisco.com> (raw)
In-Reply-To: <1464913377-30879-1-git-send-email-johndale@cisco.com>
Private/confilicting ol_flags where used to enable UDP/TCP Tx
offloads. Use the common flags in PKT_TX_L4_MASK to support them.
Also, do some minor code rearranging for slightly better performane.
Fixes: fefed3d1e62c ("enic: new driver")
Signed-off-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic.h | 1 -
drivers/net/enic/enic_rxtx.c | 28 ++++++++++++++++++----------
2 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 4b76e6d..1e6914e 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -62,7 +62,6 @@
#define ENICPMD_SETTING(enic, f) ((enic->config.flags & VENETF_##f) ? 1 : 0)
#define ENICPMD_BDF_LENGTH 13 /* 0000:00:00.0'\0' */
-#define PKT_TX_TCP_UDP_CKSUM 0x6000
#define ENIC_CALC_IP_CKSUM 1
#define ENIC_CALC_TCP_UDP_CKSUM 2
#define ENIC_MAX_MTU 9000
diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rxtx.c
index 350d04b..8fe334f 100644
--- a/drivers/net/enic/enic_rxtx.c
+++ b/drivers/net/enic/enic_rxtx.c
@@ -385,10 +385,10 @@ uint16_t enic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
struct enic *enic = vnic_dev_priv(wq->vdev);
unsigned short vlan_id;
uint64_t ol_flags;
+ uint64_t ol_flags_mask;
unsigned int wq_desc_avail;
int head_idx;
struct vnic_wq_buf *buf;
- unsigned int hw_ip_cksum_enabled;
unsigned int desc_count;
struct wq_enet_desc *descs, *desc_p, desc_tmp;
uint16_t mss;
@@ -400,10 +400,10 @@ uint16_t enic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
wq_desc_avail = vnic_wq_desc_avail(wq);
head_idx = wq->head_idx;
desc_count = wq->ring.desc_count;
+ ol_flags_mask = PKT_TX_VLAN_PKT | PKT_TX_IP_CKSUM | PKT_TX_L4_MASK;
nb_pkts = RTE_MIN(nb_pkts, ENIC_TX_XMIT_MAX);
- hw_ip_cksum_enabled = enic->hw_ip_checksum;
for (index = 0; index < nb_pkts; index++) {
tx_pkt = *tx_pkts++;
nb_segs = tx_pkt->nb_segs;
@@ -415,10 +415,9 @@ uint16_t enic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
pkt_len = tx_pkt->pkt_len;
data_len = tx_pkt->data_len;
- vlan_id = tx_pkt->vlan_tci;
ol_flags = tx_pkt->ol_flags;
-
mss = 0;
+ vlan_id = 0;
vlan_tag_insert = 0;
bus_addr = (dma_addr_t)
(tx_pkt->buf_physaddr + tx_pkt->data_off);
@@ -428,14 +427,23 @@ uint16_t enic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
eop = (data_len == pkt_len);
- if (ol_flags & PKT_TX_VLAN_PKT)
- vlan_tag_insert = 1;
+ if (ol_flags & ol_flags_mask) {
+ if (ol_flags & PKT_TX_VLAN_PKT) {
+ vlan_tag_insert = 1;
+ vlan_id = tx_pkt->vlan_tci;
+ }
- if (hw_ip_cksum_enabled && (ol_flags & PKT_TX_IP_CKSUM))
- mss |= ENIC_CALC_IP_CKSUM;
+ if (ol_flags & PKT_TX_IP_CKSUM)
+ mss |= ENIC_CALC_IP_CKSUM;
- if (hw_ip_cksum_enabled && (ol_flags & PKT_TX_TCP_UDP_CKSUM))
- mss |= ENIC_CALC_TCP_UDP_CKSUM;
+ /* Nic uses just 1 bit for UDP and TCP */
+ switch (ol_flags & PKT_TX_L4_MASK) {
+ case PKT_TX_TCP_CKSUM:
+ case PKT_TX_UDP_CKSUM:
+ mss |= ENIC_CALC_TCP_UDP_CKSUM;
+ break;
+ }
+ }
wq_enet_desc_enc(&desc_tmp, bus_addr, data_len, mss, 0, 0, eop,
eop, 0, vlan_tag_insert, vlan_id, 0);
--
2.7.0
next prev parent reply other threads:[~2016-06-03 0:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 6:32 [dpdk-dev] [PATCH v2 00/11] enic counter fixes and Tx optimization John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 01/11] enic: fix Rx drop counters John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 02/11] enic: drop bad packets and remove unused Rx error flag John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 03/11] enic: count truncated packets John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 04/11] enic: put Tx and Rx functions into same file John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 05/11] enic: remove some unused functions in Tx path John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 06/11] enic: streamline mbuf handling " John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 07/11] enic: use Tx completion messages instead of descriptors John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 08/11] enic: refactor Tx mbuf recycling John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 09/11] enic: optimize the Tx function John Daley
2016-05-30 10:05 ` Azarewicz, PiotrX T
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 10/11] enic: remove unused files and functions and variables John Daley
2016-05-24 6:32 ` [dpdk-dev] [PATCH v2 11/11] enic: add an enic assert macro John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 00/13] enic counter fixes and Tx optimization John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 01/13] enic: fix Rx drop counters John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 02/13] enic: drop bad packets and remove unused Rx error flag John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 03/13] enic: count truncated packets John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 04/13] enic: put Tx and Rx functions into same file John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 05/13] enic: remove some unused functions in Tx path John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 06/13] enic: streamline mbuf handling " John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 07/13] enic: use Tx completion messages instead of descriptors John Daley
2016-06-10 21:18 ` Bruce Richardson
2016-06-10 22:28 ` John Daley (johndale)
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 08/13] enic: refactor Tx mbuf recycling John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 09/13] enic: optimize the Tx function John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 10/13] enic: remove unused files and functions and variables John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 11/13] enic: add an enic assert macro John Daley
2016-06-03 0:22 ` [dpdk-dev] [PATCH v3 12/13] enic: expand local Tx mbuf flags variable to 64-bits John Daley
2016-06-03 8:05 ` Azarewicz, PiotrX T
2016-06-03 0:22 ` John Daley [this message]
2016-06-10 22:38 ` [dpdk-dev] [PATCH v3 00/13] enic counter fixes and Tx optimization Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464913377-30879-14-git-send-email-johndale@cisco.com \
--to=johndale@cisco.com \
--cc=bruce.richarsdon@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).