From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 96555255
 for <dev@dpdk.org>; Fri, 30 Jan 2015 23:19:48 +0100 (CET)
Received: by mail-wi0-f170.google.com with SMTP id bs8so5646866wib.1
 for <dev@dpdk.org>; Fri, 30 Jan 2015 14:19:48 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=TV7hhe1PUhLY0snsEiJFvLCc3CoGe5Q4LuaEvMnI9f0=;
 b=iygZSDJrhO7Nhq5qbDI1Festf/95Q6YPoWy/x7oi3V/JGn6LhinjElL05RGDQrgQHS
 cF21HJC6IMeCMMC7BMfYnh0KieNf/sOw2CDjmSiDjTIueqHhcBt23OTnRZyhLBiAbXQP
 5L+84/eshPI29mRC1pOQPh7Llv3PqfJXDpKV8IuuERAc9awv4jLSBgVy/IVrUA7JsRZX
 NOn5eVKNvpRPytArxfM7fUHZGo7Uxx/uPkr81nhbCaEkpuugLqN3ewYfaTOeyW0VbA2p
 tQZ8O+shl2bJDYnlhSb7FbBf2rwcCZH8KmIEG1U3BYHTqyn2DzL0+fUcBnUyhQCsEghr
 uifw==
X-Gm-Message-State: ALoCoQnkF/4JQsrNvAW6UfladSQCY1LlHtCo2Pr2h5H2dGJ8JHtwuxfkebTkfDWj4lj4T1FaKG1G
X-Received: by 10.194.62.19 with SMTP id u19mr17531392wjr.0.1422656388455;
 Fri, 30 Jan 2015 14:19:48 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id hn2sm16726318wjc.5.2015.01.30.14.19.46
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 30 Jan 2015 14:19:47 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jeff Shaw <jeffrey.b.shaw@intel.com>
Date: Fri, 30 Jan 2015 23:19:18 +0100
Message-ID: <1465014.svDMzIcz90@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <20150130214622.GA21286@plxv1142.pdx.intel.com>
References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com>
 <20150130212633.GD2664@hmsreliant.think-freely.org>
 <20150130214622.GA21286@plxv1142.pdx.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jan 2015 22:19:48 -0000

2015-01-30 13:46, Jeff Shaw:
> On Fri, Jan 30, 2015 at 04:26:33PM -0500, Neil Horman wrote:
> > On Fri, Jan 30, 2015 at 01:07:16PM +0800, Chen Jing D(Mark) wrote:
> > > From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
> > > Jeff Shaw (18):
> > >   fm10k: add base driver
[...]
> > >  lib/librte_pmd_fm10k/SHARED/fm10k_api.c         |  327 ++++
[...]
> > 
> > Why is there a SHARED directory in the driver?  Are there other drivers that use
> > the shared fm10k code?
> 
> No, the other poll-mode drivers do not use the shared fm10k code. The
> directory is similar to the 'ixgbe' and 'i40e' directories in their
> respective PMDs, only that it is named 'SHARED' for the fm10k driver.

So shared is a bad name in the context of DPDK.
Inside Intel, it can be understood that you share it between projects,
but in DPDK, it's only a base driver.

-- 
Thomas