DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE
@ 2014-06-12  8:10 Hiroshi Shimamoto
  2014-06-17  3:48 ` Xie, Huawei
  2014-06-27  0:11 ` Thomas Monjalon
  0 siblings, 2 replies; 4+ messages in thread
From: Hiroshi Shimamoto @ 2014-06-12  8:10 UTC (permalink / raw)
  To: dev; +Cc: Hayato Momma

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

The below commit requires stdio FILE structure.

commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188
Author: Stephen Hemminger <stephen@networkplumber.org>
Date:   Fri May 2 16:42:56 2014 -0700

    add FILE argument to debug functions

Application which includes rte_memory.h without stdio.h will be hit
compilation failure.

/path/to/include/rte_memory.h:146:30: error: unknown type name ‘FILE’
 void rte_dump_physmem_layout(FILE *f);

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
 lib/librte_eal/common/include/rte_memory.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h
index 7f21244..4cf8ea9 100644
--- a/lib/librte_eal/common/include/rte_memory.h
+++ b/lib/librte_eal/common/include/rte_memory.h
@@ -42,6 +42,7 @@
 
 #include <stdint.h>
 #include <stddef.h>
+#include <stdio.h>
 
 #ifdef RTE_EXEC_ENV_LINUXAPP
 #include <exec-env/rte_dom0_common.h>
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE
  2014-06-12  8:10 [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE Hiroshi Shimamoto
@ 2014-06-17  3:48 ` Xie, Huawei
  2014-06-25  9:51   ` Thomas Monjalon
  2014-06-27  0:11 ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Xie, Huawei @ 2014-06-17  3:48 UTC (permalink / raw)
  To: Hiroshi Shimamoto, dev; +Cc: Hayato Momma

Hi Shimamoto:
At least rte_tailq.h, rte_mbuf.h should also include stdio.h.

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto
Sent: Thursday, June 12, 2014 4:11 PM
To: dev@dpdk.org
Cc: Hayato Momma
Subject: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

The below commit requires stdio FILE structure.

commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188
Author: Stephen Hemminger <stephen@networkplumber.org>
Date:   Fri May 2 16:42:56 2014 -0700

    add FILE argument to debug functions

Application which includes rte_memory.h without stdio.h will be hit compilation failure.

/path/to/include/rte_memory.h:146:30: error: unknown type name 'FILE'
 void rte_dump_physmem_layout(FILE *f);

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
 lib/librte_eal/common/include/rte_memory.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h
index 7f21244..4cf8ea9 100644
--- a/lib/librte_eal/common/include/rte_memory.h
+++ b/lib/librte_eal/common/include/rte_memory.h
@@ -42,6 +42,7 @@
 
 #include <stdint.h>
 #include <stddef.h>
+#include <stdio.h>
 
 #ifdef RTE_EXEC_ENV_LINUXAPP
 #include <exec-env/rte_dom0_common.h>
--
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE
  2014-06-17  3:48 ` Xie, Huawei
@ 2014-06-25  9:51   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2014-06-25  9:51 UTC (permalink / raw)
  To: Xie, Huawei; +Cc: dev, Hayato Momma

Hi Huawei,

2014-06-17 03:48, Xie, Huawei:
> At least rte_tailq.h, rte_mbuf.h should also include stdio.h.

It has been fixed in this commit:
	http://dpdk.org/browse/dpdk/commit/?id=86d5de5c46fc0
But rte_memory.h was forgotten.
rte_mbuf.h has no problem because it includes rte_mempool.h which includes 
stdio.h.

-- 
Thomas


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto
> Sent: Thursday, June 12, 2014 4:11 PM
> To: dev@dpdk.org
> Cc: Hayato Momma
> Subject: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE
> 
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> 
> The below commit requires stdio FILE structure.
> 
> commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188
> Author: Stephen Hemminger <stephen@networkplumber.org>
> Date:   Fri May 2 16:42:56 2014 -0700
> 
>     add FILE argument to debug functions
> 
> Application which includes rte_memory.h without stdio.h will be hit
> compilation failure.
> 
> /path/to/include/rte_memory.h:146:30: error: unknown type name 'FILE'
>  void rte_dump_physmem_layout(FILE *f);
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
> ---
>  lib/librte_eal/common/include/rte_memory.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_memory.h
> b/lib/librte_eal/common/include/rte_memory.h index 7f21244..4cf8ea9 100644
> --- a/lib/librte_eal/common/include/rte_memory.h
> +++ b/lib/librte_eal/common/include/rte_memory.h
> @@ -42,6 +42,7 @@
> 
>  #include <stdint.h>
>  #include <stddef.h>
> +#include <stdio.h>
> 
>  #ifdef RTE_EXEC_ENV_LINUXAPP
>  #include <exec-env/rte_dom0_common.h>
> --
> 1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE
  2014-06-12  8:10 [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE Hiroshi Shimamoto
  2014-06-17  3:48 ` Xie, Huawei
@ 2014-06-27  0:11 ` Thomas Monjalon
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2014-06-27  0:11 UTC (permalink / raw)
  To: Hiroshi Shimamoto; +Cc: dev, Hayato Momma

> The below commit requires stdio FILE structure.
> 
> commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188
> Author: Stephen Hemminger <stephen@networkplumber.org>
> Date:   Fri May 2 16:42:56 2014 -0700
> 
>     add FILE argument to debug functions
> 
> Application which includes rte_memory.h without stdio.h will be hit
> compilation failure.
> 
> /path/to/include/rte_memory.h:146:30: error: unknown type name ‘FILE’
>  void rte_dump_physmem_layout(FILE *f);
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.0.

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-06-27  0:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-12  8:10 [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE Hiroshi Shimamoto
2014-06-17  3:48 ` Xie, Huawei
2014-06-25  9:51   ` Thomas Monjalon
2014-06-27  0:11 ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git