DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] ip_pipeline: add flow actions pipeline
Date: Mon, 07 Dec 2015 12:57:56 +0100	[thread overview]
Message-ID: <1465661.sXytVPa95X@xps13> (raw)
In-Reply-To: <566548AC.6020807@redhat.com>

2015-12-07 10:51, Panu Matilainen:
> On 12/07/2015 03:17 AM, Thomas Monjalon wrote:
> > 2015-11-18 17:09, Fan Zhang:
> >> Flow actions pipeline is an extension of flow-classification pipeline.
> >> Some of the operations of flow classification pipeline such as traffic
> >> metering/marking(for e.g. Single Rate Three Color Marker (srTCM), Two
> >> Rate Three Color Marker trTCM)), policer can be performed separately in
> >> flow action pipeline to avoid excessive computational burden on the CPU
> >> core running the flow-classification pipeline. The Flow action pipeline
> >> implements various function such as traffic metering, policer, stats.
> >> Traffic mettering can configured as per the required context, for
> >> examples- per user, per traffic class or both. These contexts can be
> >> applied by specifying parameters in configuration file as shown below;
> >>
> >> [PIPELINE1]
> >> type = FLOW_ACTIONS
> >> core = 1
> >> pktq_in = RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0
> >> pktq_out = TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0
> >> n_flows = 65536
> >> n_meters_per_flow = 1
> >> flow_id_offset = 158
> >> ip_hdr_offset = 142
> >> color_offset = 64
> >>
> >> The entries of flow and dscp tables of flow actions pipeline can be
> >> modified through command-line interface. The commands to add or delete
> >> entries to the flow table, DSCP(differentiated services code point)
> >> table and for statistics collection, etc have been included. The key
> >> functions such as Traffic Metering/marking and policer functions have
> >> been implemented as flow-table action handler.
> >>
> >> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> >> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> >> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >
> > Applied, thanks
> >
> 
> The patch tries to include pipeline_flow_actions.h which doesn't exist, 
> making the ip_pipeline example unbuildable.
> 
> Seems like a case of forgotten "git add" when creating the patch...

Yes you are right. My bad.
I had to resolve some conflicts and forgot these "git add".
It is fixed now. Thank you for reporting.

  reply	other threads:[~2015-12-07 11:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 17:09 Fan Zhang
2015-12-07  1:17 ` Thomas Monjalon
2015-12-07  8:51   ` Panu Matilainen
2015-12-07 11:57     ` Thomas Monjalon [this message]
2015-12-07  9:44   ` Singh, Jasvinder
2015-12-07 12:00     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465661.sXytVPa95X@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).