From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] fix of configuring inside NIC RX interrupt
Date: Wed, 29 Oct 2014 23:44:41 +0100 [thread overview]
Message-ID: <1465780.2TIMX0FgGe@xps13> (raw)
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D01604298@shsmsx102.ccr.corp.intel.com>
2014-10-29 05:00, Chen, Jing D:
> From: Zhang, Helin
> > Inside NIC RX interrupt is needed for single RX descriptor
> > write back. The fix is to correct the wrong configuration
> > of register 'I40E_QINT_RQCTL'. In addition, several code
> > style fixes are added.
> > Note that interrupt will be inside NIC only, that means it
> > will never be reported outside NIC hardware.
> >
> > Helin Zhang (2):
> > i40e: code style fix
> > i40e: fix of configuring inside NIC RX interrupt
>
> Acked-by: Jing Chen <jing.d.chen@intel.com>
Applied
About commit log of the second patch:
- title of a fix should show which feature is fixed, not how it is fixed
- content of the commit log should explain what was broken
Thanks
--
Thomas
prev parent reply other threads:[~2014-10-29 22:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 3:42 Helin Zhang
2014-10-29 3:42 ` [dpdk-dev] [PATCH 1/2] i40e: code style fix Helin Zhang
2014-10-29 6:11 ` Qiu, Michael
2014-10-29 6:26 ` Zhang, Helin
2014-10-29 8:06 ` Qiu, Michael
2014-10-29 3:42 ` [dpdk-dev] [PATCH 2/2] i40e: fix of configuring inside NIC RX interrupt Helin Zhang
2014-10-29 5:00 ` [dpdk-dev] [PATCH 0/2] " Chen, Jing D
2014-10-29 22:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465780.2TIMX0FgGe@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).