From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 05CB12A9 for ; Wed, 29 Oct 2014 23:36:07 +0100 (CET) Received: by mail-wg0-f51.google.com with SMTP id l18so2937306wgh.38 for ; Wed, 29 Oct 2014 15:45:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=cIFgkRkchkz1NJTcddiJPu8YJ5SMzLbpujhUknLIecA=; b=jbCle4NlZrPOys03uN5GaGG7v2J1NSr0DO7IWKzuxdya9GUMKhjeKkVTJwrc/uHsB2 S4l0YFHdyXZNIQesQAYYCYMohphX4wS4IbYBINKCRyDtHRWsyFXhVFfp4lgAaram1o7s SBtWyhUk+nMyRGqrFxFmF2DSHTOVI5X5yFtFlu1f513FzQm/jqZD4NomGKdddC/9AWlx 2GyTenT5iLQ78N0cOy6V7XDYiOl3h7PqWOW2k1mW2RYM34/ClchOQamEV4O5PhweD4L3 Wr17E9XdSrw6IWUQkNSkfR4Lbk/Xl5xcRi1SEqtSVeBYomheAXDtfqDKxAQOzWgAzxEl 0egQ== X-Gm-Message-State: ALoCoQnHAIMLrdzZNy9LgX7OD1YTeBEAN309QZ/J71LtehQsKADO0Eo8JNaOMUH1NJg3SJLWM7gY X-Received: by 10.194.23.104 with SMTP id l8mr15496980wjf.26.1414622700459; Wed, 29 Oct 2014 15:45:00 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bl9sm20172701wib.24.2014.10.29.15.44.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Oct 2014 15:44:59 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Wed, 29 Oct 2014 23:44:41 +0100 Message-ID: <1465780.2TIMX0FgGe@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D01604298@shsmsx102.ccr.corp.intel.com> References: <1414554168-5117-1-git-send-email-helin.zhang@intel.com> <4341B239C0EFF9468EE453F9E9F4604D01604298@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] fix of configuring inside NIC RX interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 22:36:07 -0000 2014-10-29 05:00, Chen, Jing D: > From: Zhang, Helin > > Inside NIC RX interrupt is needed for single RX descriptor > > write back. The fix is to correct the wrong configuration > > of register 'I40E_QINT_RQCTL'. In addition, several code > > style fixes are added. > > Note that interrupt will be inside NIC only, that means it > > will never be reported outside NIC hardware. > > > > Helin Zhang (2): > > i40e: code style fix > > i40e: fix of configuring inside NIC RX interrupt > > Acked-by: Jing Chen Applied About commit log of the second patch: - title of a fix should show which feature is fixed, not how it is fixed - content of the commit log should explain what was broken Thanks -- Thomas