From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bairemon@ecsmtp.ir.intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id B1C0E9AA7
for <dev@dpdk.org>; Tue, 14 Jun 2016 17:36:01 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by fmsmga102.fm.intel.com with ESMTP; 14 Jun 2016 08:36:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,471,1459839600"; d="scan'208";a="997438118"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
by orsmga002.jf.intel.com with ESMTP; 14 Jun 2016 08:35:53 -0700
Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com
[10.237.217.45])
by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
u5EFZq2t012302; Tue, 14 Jun 2016 16:35:52 +0100
Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1])
by sivswdev01.ir.intel.com with ESMTP id u5EFZpFX015617;
Tue, 14 Jun 2016 16:35:51 +0100
Received: (from bairemon@localhost)
by sivswdev01.ir.intel.com with id u5EFZpVA015611;
Tue, 14 Jun 2016 16:35:51 +0100
From: Bernard Iremonger <bernard.iremonger@intel.com>
To: dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com,
Bernard Iremonger <bernard.iremonger@intel.com>
Date: Tue, 14 Jun 2016 16:35:40 +0100
Message-Id: <1465918542-15512-8-git-send-email-bernard.iremonger@intel.com>
X-Mailer: git-send-email 1.7.4.1
In-Reply-To: <1465918542-15512-1-git-send-email-bernard.iremonger@intel.com>
References: <1465907296-27117-1-git-send-email-bernard.iremonger@intel.com>
<1465918542-15512-1-git-send-email-bernard.iremonger@intel.com>
Subject: [dpdk-dev] [PATCH v5 7/9] app/testpmd: check for valid socket id
when attaching port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2016 15:36:02 -0000
Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
app/test-pmd/testpmd.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 38cddca..fa6434c 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1527,6 +1527,7 @@ void
attach_port(char *identifier)
{
portid_t pi = 0;
+ unsigned int socket_id;
printf("Attaching a new port...\n");
@@ -1539,7 +1540,11 @@ attach_port(char *identifier)
return;
ports[pi].enabled = 1;
- reconfig(pi, rte_eth_dev_socket_id(pi));
+ socket_id = (unsigned)rte_eth_dev_socket_id(pi);
+ /* if socket_id is invalid, set to 0 */
+ if (check_socket_id(socket_id) < 0)
+ socket_id = 0;
+ reconfig(pi, socket_id);
rte_eth_promiscuous_enable(pi);
nb_ports = rte_eth_dev_count();
--
2.6.3