From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 3AC15C4D2 for ; Thu, 16 Jun 2016 04:33:31 +0200 (CEST) Received: by mail-pf0-f177.google.com with SMTP id c2so14769037pfa.2 for ; Wed, 15 Jun 2016 19:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=b5Ia9i+BJITzikX3VkZOXCeLaCa9Pd9aN3ZUTDCaFFo=; b=eTLTj4v2ogLqqlwqDFLy/VSGnHVZZUG6OEEHolnrc7ZIsiR73YBwwoaQtYIj/0T71Q 5cH+0qfV1TnnnSV68zFi7fqXOBPJ7h8m9FXvBvjFjNORPA+9CYCIXb4l1XZT3ntqNq1U WGcXaFlG1KbTKNOXjSF7VfOtBriyITE7GwEzqE4z2TaN89KoiADuw2gjC0+3NFEQHFE4 VfVX2PP1CFYkevaMjolMz/wISC0k4Y9SRrgkYWW61m7EZpjjhnojK3f+z4zQXMRcHuH4 RW5jaQrOwdS2XflrJp8IdnmXP8ImKeDAUv7jhqOVwM9zsK/j10fSYto7NSjYhl3j3Xa8 auSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=b5Ia9i+BJITzikX3VkZOXCeLaCa9Pd9aN3ZUTDCaFFo=; b=LwlGPR5uAV+zjFH+D7A51lBRhjVTx5fVVMxrzeSdcdq7NDbeel4DZp5LsPWDMs+F+m MudEL/dzqlbT1xc2ioAS4Py/OGpAsG96g9pFFen5dtgbif2MtXeNecUKMvAkrxf+mpR6 /6m5lGLCev9oWLbqFaUl7v/aNqgAw1IxitwNVHt4Ewn+FkgGQmfmX9Hwfu4AQclyjbqG LS/zgfk1bgaiZHiFFiw58GOuCthUizTlsdYA4FUZEPdROCLa5lVzQp1VJ51vu26TfZzA 5FNsgxbhHu+Dow9MYggRR/yEI/z2DLbFbDd6/dJ5DVze2oNKLZMmhYbptUVFb3IW3f+T 6g4w== X-Gm-Message-State: ALyK8tIhsGhA7kmYkRjRpxrj1ZFQhuew1oQQDvQTfmLFpeNFWhoppDe6QPWwfk+3pgrJtQ== X-Received: by 10.98.96.67 with SMTP id u64mr2265740pfb.152.1466044410491; Wed, 15 Jun 2016 19:33:30 -0700 (PDT) Received: from localhost.localdomain (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id x10sm47039895pfd.8.2016.06.15.19.33.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Jun 2016 19:33:29 -0700 (PDT) From: Tetsuya Mukawa To: dev@dpdk.org Cc: david.marchand@6wind.com, john.mcnamara@intel.com, michalx.k.jastrzebski@intel.com, Tetsuya Mukawa Date: Thu, 16 Jun 2016 11:33:09 +0900 Message-Id: <1466044391-3210-1-git-send-email-mukawa@igel.co.jp> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1465961209-28309-1-git-send-email-mukawa@igel.co.jp> References: <1465961209-28309-1-git-send-email-mukawa@igel.co.jp> Subject: [dpdk-dev] [PATCH v2] eal: Fix wrong error checking while parsing device arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 02:33:31 -0000 This patch fixes wrong error checking of rte_eal_parse_devargs_str(). Currently, a return value of strdup() is wrongly checked. Fixes: 0fe11ec592b2 ("eal: add vdev init and uninit") Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 2bfe54a..e403717 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -58,7 +58,7 @@ rte_eal_parse_devargs_str(const char *devargs_str, return -1; *drvname = strdup(devargs_str); - if (drvname == NULL) + if (*drvname == NULL) return -1; /* set the first ',' to '\0' to split name and arguments */ -- 2.7.4