From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 44B3EC5E4 for ; Thu, 16 Jun 2016 11:17:02 +0200 (CEST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O8U00H72XSC5E50@mailout1.w1.samsung.com> for dev@dpdk.org; Thu, 16 Jun 2016 10:17:00 +0100 (BST) X-AuditID: cbfec7f5-f792a6d000001302-67-57626e8b9111 Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id EF.63.04866.B8E62675; Thu, 16 Jun 2016 10:16:59 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O8U000IUXRWS090@eusync4.samsung.com>; Thu, 16 Jun 2016 10:16:59 +0100 (BST) From: Ilya Maximets To: dev@dpdk.org, Huawei Xie , Yuanhan Liu Cc: Dyasly Sergey , Heetae Ahn , Vladimir Shilkin , Victor Kaplansky , Ilya Maximets Date: Thu, 16 Jun 2016 12:16:36 +0300 Message-id: <1466068597-3449-2-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1466068597-3449-1-git-send-email-i.maximets@samsung.com> References: <1466068597-3449-1-git-send-email-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBLMWRmVeSWpSXmKPExsVy+t/xa7rdeUnhBltXWVm8+7SdyWLa59vs Fu0zzzJZXGn/yW4xebaUxeRNKxgtFh84zGxxfcIFVgcOj18LlrJ6LN7zkslj3slAj/f7rrJ5 9G1ZxRjAGsVlk5Kak1mWWqRvl8CVse/RbLaC9zwVZz+1sTcwHufqYuTkkBAwkdj8/iUjhC0m ceHeejYQW0hgKaPEgjXeXYxcQHYrk8TKM8+ZQRJsAjoSp1YfAWsQEUiQOLL/NytIEbPAOUaJ JVfWMIEkhAVsJBZv2QpWxCKgKnH35FGwOK+Aq8T8i90sENvkJG6e6wQbyingJvHmwiFWiM2u Epv6ZzBPYORdwMiwilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkvL7uYFx6zOoQowAHoxIP r8D6xHAh1sSy4srcQ4wSHMxKIrzyWUnhQrwpiZVVqUX58UWlOanFhxilOViUxHln7nofIiSQ nliSmp2aWpBaBJNl4uCUamCcvvql4/9fT4vYJaWXfXXy+fjSKuN2kvOu2JN3uwP+3Xjc4/55 4YyPqfImRywezRJes2DVjKzLK/cqN8jGFm8Jfdh++nTZj/p5gsILLa1a5vXVer1a83GnI6Nw Lbug4OHeF+c+h7D8YP/PdFb3tlmBg3/8LVZ215rOVP3Du9rmGYrMqEjKF9ZWYinOSDTUYi4q TgQAWxS+3CsCAAA= Subject: [dpdk-dev] [PATCH v2 1/2] vhost: fix leak of file descriptors. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 09:17:02 -0000 While migration of vhost-user device QEMU allocates memfd to store information about dirty pages and sends fd to vhost-user process. File descriptor for this memory should be closed to prevent "Too many open files" error for vhost-user process after some amount of migrations. Ex.: # ls /proc//fd/ -alh total 0 root qemu . root qemu .. root qemu 0 -> /dev/pts/0 root qemu 1 -> pipe:[1804353] root qemu 10 -> socket:[1782240] root qemu 100 -> /memfd:vhost-log (deleted) root qemu 1000 -> /memfd:vhost-log (deleted) root qemu 1001 -> /memfd:vhost-log (deleted) root qemu 1004 -> /memfd:vhost-log (deleted) [...] root qemu 996 -> /memfd:vhost-log (deleted) root qemu 997 -> /memfd:vhost-log (deleted) ovs-vswitchd.log: |WARN|punix:ovs-vswitchd.ctl: accept failed: Too many open files Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request") Signed-off-by: Ilya Maximets --- lib/librte_vhost/vhost_user/virtio-net-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c b/lib/librte_vhost/vhost_user/virtio-net-user.c index 64a6ec4..e6a2aed 100644 --- a/lib/librte_vhost/vhost_user/virtio-net-user.c +++ b/lib/librte_vhost/vhost_user/virtio-net-user.c @@ -401,6 +401,7 @@ user_set_log_base(int vid, struct VhostUserMsg *msg) * fail when offset is not page size aligned. */ addr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + close(fd); if (addr == MAP_FAILED) { RTE_LOG(ERR, VHOST_CONFIG, "mmap log base failed!\n"); return -1; -- 2.7.4