From: Remy Horton <remy.horton@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 2/2] examples/l2fwd-keepalive: fix Coverity issues
Date: Mon, 20 Jun 2016 16:23:07 +0100 [thread overview]
Message-ID: <1466436187-5225-3-git-send-email-remy.horton@intel.com> (raw)
In-Reply-To: <1466436187-5225-1-git-send-email-remy.horton@intel.com>
Fixes memory leaks detected by Coverity. These are due to ephemeral
memory allocations not being freed when errors occur.
Coverity issue 127349: Resource leak
Fixes: e2aae1c1ced9 ("ethdev: remove name from extended statistic fetch")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
examples/l2fwd-keepalive/shm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/examples/l2fwd-keepalive/shm.c b/examples/l2fwd-keepalive/shm.c
index 66fc433..177aa5b 100644
--- a/examples/l2fwd-keepalive/shm.c
+++ b/examples/l2fwd-keepalive/shm.c
@@ -80,6 +80,8 @@ struct rte_keepalive_shm *rte_keepalive_shm_create(void)
RTE_LOG(INFO, EAL,
"Failed to setup SHM semaphore (%s)\n",
strerror(errno));
+ munmap(ka_shm,
+ sizeof(struct rte_keepalive_shm));
return NULL;
}
--
2.5.5
next prev parent reply other threads:[~2016-06-20 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 13:49 [dpdk-dev] [PATCH v1] app: " Remy Horton
2016-06-20 13:56 ` Thomas Monjalon
2016-06-20 14:50 ` Remy Horton
2016-06-20 15:23 ` [dpdk-dev] [PATCH v2 0/2] " Remy Horton
2016-06-20 15:23 ` [dpdk-dev] [PATCH v2 1/2] app/test-pmd: " Remy Horton
2016-06-20 15:33 ` De Lara Guarch, Pablo
2016-06-20 15:23 ` Remy Horton [this message]
2016-06-21 13:58 ` [dpdk-dev] [PATCH v2 0/2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466436187-5225-3-git-send-email-remy.horton@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).