From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 60A41ADBE for ; Wed, 25 Jun 2014 11:26:57 +0200 (CEST) Received: by mail-wi0-f179.google.com with SMTP id cc10so2167661wib.12 for ; Wed, 25 Jun 2014 02:27:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=BOA7DsZVjUKWKvnTFb0y2NiBnRNA5cSEsNQb9rsFG9Y=; b=AJZZ/xCDeFqJg1QrDFR7uNZoP3z3gLNUocJSX74NoJJoMh0e1tC3W2R4a1Wd1CaWN2 K2DBSx6QXOQKYp/YWmGYk35d1GFWhOH7S5Uj0SXnw+bjA+dtoMnzrTLj1mSjGVdRkIRp CQDOXJaPrPuSh22TKeTJaDSmvtBTZPPL0+2izMPK/7gh8oayQOokkJVwUJzdbrrD/l5z ziI7nWOB1fKtIibSx56fFtvqe+nDUrGK97MsXJ9nimVTt/3CQBmQheEB9lIoYfQmUHeI fA205fmELuPTmEfQDmsiHs65T2siRSipHvY7KUn4lc7qpxVxxOD0vn4EYcJEmpM8/1q5 pK+w== X-Gm-Message-State: ALoCoQlRiFRN6RagNodwqWjHU6IQ5OrusRfnRQ4vhkgwPgeJU/tczdO2QgbN3GQHrzOJaX9YXN/K X-Received: by 10.180.20.112 with SMTP id m16mr2672407wie.6.1403688433917; Wed, 25 Jun 2014 02:27:13 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fb8sm7093331wib.15.2014.06.25.02.27.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2014 02:27:13 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Wed, 25 Jun 2014 11:27:01 +0200 Message-ID: <1466647.TRuQXWIUSI@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <4709584.nAXykbU3l6@xps13> References: <20140619151238.28b9bbea@nehalam.linuxnetplumber.net> <4709584.nAXykbU3l6@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] rte_ethdev: add link support flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 09:26:57 -0000 Hi Stephen, I had no answer to this comment. Please check. 2014-06-20 15:06, Thomas Monjalon: > 2014-06-19 15:12, Stephen Hemminger: > > Only some devices support the link state interrupt configuration option. > > Link state control does not work in virtual drivers > > (virtio, vmxnet3, igbvf, and ixgbevf). Instead of having the application > > try and guess whether it will work or not provide a driver flag that > > can be checked instead. > > > > Note: if device driver doesn't support link state control, what > > would happen previously is that the code would never detect link > > transitions. This prevents that. > > [...] > > > @@ -197,6 +197,8 @@ struct rte_pci_driver { > > > > #define RTE_PCI_DRV_MULTIPLE 0x0002 > > /** Device needs to be unbound even if no module is provided */ > > #define RTE_PCI_DRV_FORCE_UNBIND 0x0004 > > > > +/** Device driver supports link state interrupt */ > > +#define RTE_PCI_DRV_LSC 0x0008 > > I feel RTE_PCI_DRV_INTR_LSC would be easier to understand. > Do you agree? > > Note that related event is RTE_ETH_EVENT_INTR_LSC > and configuration is intr_conf.lsc. > > Title should be "ethdev: add link state interrupt flag". A v3 would be nice. Thanks -- Thomas