From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id 777D4C410 for ; Sat, 25 Jun 2016 12:30:15 +0200 (CEST) Received: by mail-pf0-f194.google.com with SMTP id c74so11446431pfb.0 for ; Sat, 25 Jun 2016 03:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TqVQxDhxAFX4aOIUstulgr+Xf/oc9f0yNrXt+mWLD60=; b=d5/bgBl8Kyg/KYpoDoraQ8W6ENFHXD/kUkHbROzqaKBoLcjaFGO1fFVtvAso/cE7G4 250o3HaMoAqBvwQQxTkUG6Rc0Oh+xVYaLdixOwjoV+oeaU/sxu+daz2cPmrbg2AnwmsZ 1cmyIi3JJ0pN2DWn8gUUz/LqZ8Xw4M0Hy5ZCXpVGUy397DIMCBJPuLRyi1OWnncgTqWZ 6OSgpY0zznOTdC0arPWVBdT8sfuL/2x6EJuna24tAVlz9nHcnN4RW3awb8GHH2GNxNQi bY0AMcWSY9vddtSEO/xUxG85QWjlE7k5YLsWhsW0hEgmnj79TYdYSFwGltWUgjugP+Af d6GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TqVQxDhxAFX4aOIUstulgr+Xf/oc9f0yNrXt+mWLD60=; b=fdB8872tFPoZ1TkZwfBAZTvFasBBERIR4KNspPUh4C+4qiRc2nUXC4lcCebAxwvsY0 lDnm7T3ro/b+d+cGTCda+y1p4fFDJGapePZBU3VZp2l3emdiWUkHQ/H+Je0VqRJ/jKnV o5YrJa/kTMSfge17lPheafmreSmmdk0dQlb9SbGE26sVTItxSNLerLpYBKYyLAuW0Qn3 BSpfO57Un/qkT953sSBuScNR00ySKdquVb9C6Jb+L7QdCbZkV/lzU5g/0Vjpq26qzuvF XOTea0OkWl56grD1kvVJlrGN0H6kHkDWhN2FWTvUlTMjE1CVDfvNN4HBsOIslYCg6c8M Fecg== X-Gm-Message-State: ALyK8tIjuks903wwuRxHL6jg4KbaQ7p9yW9woL0LTPeo3RA8ZiVCc7nPa6sYgaKYrq6glA== X-Received: by 10.98.73.198 with SMTP id r67mr15555229pfi.50.1466850614690; Sat, 25 Jun 2016 03:30:14 -0700 (PDT) Received: from localhost.localdomain ([12.218.209.105]) by smtp.gmail.com with ESMTPSA id z88sm6267585pfa.59.2016.06.25.03.30.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 25 Jun 2016 03:30:14 -0700 (PDT) From: Rugang Chen To: dev@dpdk.org Cc: Rugang Chen Date: Sat, 25 Jun 2016 03:30:00 -0700 Message-Id: <1466850600-1483-1-git-send-email-rugangchen2011@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466815528-27163-1-git-send-email-rugangchen2011@gmail.com> References: <1466815528-27163-1-git-send-email-rugangchen2011@gmail.com> Subject: [dpdk-dev] [PATCH] pci: don't insert an unbound device to pci_device_list in pci_scan_one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2016 10:30:15 -0000 If a device isn't bound by any uio driver (vfio-pci, igb_uio, uio_pci_generic) and is expected to owned by a kernel space driver, here it's still inserted to pci_device_list. This may cause application based on dpdk fetch the device by accident and then the device is hanlded by dpdk. For safe, skip it from pci_device_list as if it's unbound, dpdk won't want to use it. --- lib/librte_eal/linuxapp/eal/eal_pci.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c index f63febc..432d2e8 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c @@ -392,8 +392,12 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus, * fetch it from pci_device_list by accident and then dpdk handles it. Kernel * space driver maybe wants to own it. */ - if (dev->kdrv == RTE_KDRV_NONE) + if (dev->kdrv == RTE_KDRV_NONE) { + RTE_LOG(WARNING, EAL, "Skip ubound device\n"); + free(dev); return 0; + } + /* device is valid, add in list (sorted) */ if (TAILQ_EMPTY(&pci_device_list)) { TAILQ_INSERT_TAIL(&pci_device_list, dev, next); -- 2.1.4