From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 481585683 for ; Tue, 28 Jun 2016 05:58:24 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 27 Jun 2016 20:58:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,539,1459839600"; d="scan'208";a="836360686" Received: from unknown (HELO yliu-dev.sh.intel.com) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 27 Jun 2016 20:58:23 -0700 From: Yuanhan Liu To: dev@dpdk.org Cc: huawei.xie@intel.com, John McNamara , Yuanhan Liu Date: Tue, 28 Jun 2016 11:58:30 +0800 Message-Id: <1467086311-13527-3-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1467086311-13527-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1467086311-13527-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-dev] [PATCH 2/3] vhost: fix not null terminated string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2016 03:58:25 -0000 Fix an issue raised by Coverity. >>> CID 127475: Memory - illegal accesses (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 108 bytes on >>> destination array "un->sun_path" of size 108 bytes might leave >>> the destination string unterminated. 441 strncpy(un->sun_path, path, sizeof(un->sun_path)); 442 443 return fd; 444 } Coverity issue: 127475 Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode") Reported-by: John McNamara Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost_user/vhost-net-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c b/lib/librte_vhost/vhost_user/vhost-net-user.c index 90cc127..67303a4 100644 --- a/lib/librte_vhost/vhost_user/vhost-net-user.c +++ b/lib/librte_vhost/vhost_user/vhost-net-user.c @@ -439,6 +439,7 @@ create_unix_socket(const char *path, struct sockaddr_un *un, bool is_server) memset(un, 0, sizeof(*un)); un->sun_family = AF_UNIX; strncpy(un->sun_path, path, sizeof(un->sun_path)); + un->sun_path[sizeof(un->sun_path) - 1] = '\0'; return fd; } -- 1.9.0