From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: <dev@dpdk.org>
Cc: <thomas.monjalon@6wind.com>, <olivier.matz@6wind.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH v3] mempool: replace c memcpy code semantics with optimized rte_memcpy
Date: Thu, 30 Jun 2016 17:46:36 +0530 [thread overview]
Message-ID: <1467288996-6109-1-git-send-email-jerin.jacob@caviumnetworks.com> (raw)
In-Reply-To: <1464250025-9191-1-git-send-email-jerin.jacob@caviumnetworks.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---
v1..v2
Corrected the the git commit message(s/mbuf/mempool/g)
v2..v3
re-base to master
---
---
lib/librte_mempool/rte_mempool.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index b2a5197..c8a81e2 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -74,6 +74,7 @@
#include <rte_memory.h>
#include <rte_branch_prediction.h>
#include <rte_ring.h>
+#include <rte_memcpy.h>
#ifdef __cplusplus
extern "C" {
@@ -1028,7 +1029,6 @@ static inline void __attribute__((always_inline))
__mempool_generic_put(struct rte_mempool *mp, void * const *obj_table,
unsigned n, struct rte_mempool_cache *cache, int flags)
{
- uint32_t index;
void **cache_objs;
/* increment stat now, adding in mempool always success */
@@ -1052,8 +1052,7 @@ __mempool_generic_put(struct rte_mempool *mp, void * const *obj_table,
*/
/* Add elements back into the cache */
- for (index = 0; index < n; ++index, obj_table++)
- cache_objs[index] = *obj_table;
+ rte_memcpy(&cache_objs[0], obj_table, sizeof(void *) * n);
cache->len += n;
--
2.5.5
next prev parent reply other threads:[~2016-06-30 12:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:50 [dpdk-dev] [PATCH] mbuf: " Jerin Jacob
2016-05-24 14:59 ` Olivier Matz
2016-05-24 15:17 ` Jerin Jacob
2016-05-27 10:24 ` Hunt, David
2016-05-27 11:42 ` Jerin Jacob
2016-05-27 15:05 ` Thomas Monjalon
2016-05-30 8:44 ` Olivier Matz
2016-05-27 13:45 ` Hunt, David
2016-06-24 15:56 ` Hunt, David
2016-06-24 16:02 ` Olivier Matz
2016-05-26 8:07 ` [dpdk-dev] [PATCH v2] mempool: " Jerin Jacob
2016-05-30 8:45 ` Olivier Matz
2016-05-31 12:58 ` Jerin Jacob
2016-05-31 21:05 ` Olivier MATZ
2016-06-01 7:00 ` Jerin Jacob
2016-06-02 7:36 ` Olivier MATZ
2016-06-02 9:39 ` Jerin Jacob
2016-06-02 21:16 ` Olivier MATZ
2016-06-03 7:02 ` Jerin Jacob
2016-06-17 10:40 ` Olivier Matz
2016-06-24 16:04 ` Olivier Matz
2016-06-30 9:41 ` Thomas Monjalon
2016-06-30 11:38 ` Jerin Jacob
2016-06-30 12:16 ` Jerin Jacob [this message]
2016-06-30 17:28 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2016-07-05 8:43 ` Ferruh Yigit
2016-07-05 11:32 ` Yuanhan Liu
2016-07-05 13:13 ` Jerin Jacob
2016-07-05 13:42 ` Yuanhan Liu
2016-07-05 14:09 ` Ferruh Yigit
2016-07-06 16:21 ` Ferruh Yigit
2016-07-07 13:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467288996-6109-1-git-send-email-jerin.jacob@caviumnetworks.com \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).