From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: [dpdk-dev] [PATCH 3/3] scripts: check headline of drivers commits
Date: Wed, 6 Jul 2016 12:38:50 +0200 [thread overview]
Message-ID: <1467801530-20800-4-git-send-email-thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com>
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
A driver patch under net should start with "net/<driver name>" or if
a patch touch multiple drivers, it should only start with "net:".
The same apply for crypto.
A patch touching all drivers (net + crypto) should start with "drivers:".
Longer prefixes like "net/mlx:" (for mlx4/mlx5) or "net/e1000/base:" are
handled by not checking the colon.
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
scripts/check-git-log.sh | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 833aa39..3f3cf19 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -70,6 +70,23 @@ bad=$(echo "$headlines" | grep --color=always \
| sed 's,^,\t,')
[ -z "$bad" ] || printf "Wrong headline format:\n$bad\n"
+# check headline prefix when touching only drivers/, e.g. net/<driver name>
+bad=$(for commit in $commits ; do
+ headline=$(git log --format='%s' -1 $commit)
+ files=$(git diff-tree --no-commit-id --name-only -r $commit)
+ [ -z "$(echo "$files" | grep -v '^drivers/')" ] || continue
+ driversgrp=$(echo "$files" | cut -d "/" -f 2 | sort -u)
+ drivers=$(echo "$files" | cut -d "/" -f 2,3 | sort -u)
+ if [ $(echo "$driversgrp" | wc -l) -gt 1 ] ; then
+ bad=$(echo "$headline" | grep -v '^drivers:')
+ elif [ $(echo "$drivers" | wc -l) -gt 1 ] ; then
+ bad=$(echo "$headline" | grep -v "^$driversgrp")
+ else
+ bad=$(echo "$headline" | grep -v "^$drivers")
+ fi
+done | sed 's,^,\t,')
+[ -z "$bad" ] || printf "Wrong headline prefix:\n$bad\n"
+
# check headline label for common typos
bad=$(echo "$headlines" | grep --color=always \
-e '^example[:/]' \
--
2.7.0
next prev parent reply other threads:[~2016-07-06 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 10:38 [dpdk-dev] [PATCH 0/3] more commits checks Thomas Monjalon
2016-07-06 10:38 ` [dpdk-dev] [PATCH 1/3] scripts: check spacing after commit references Thomas Monjalon
2016-07-06 10:38 ` [dpdk-dev] [PATCH 2/3] scripts: reduce line size of commit checks Thomas Monjalon
2016-07-06 10:38 ` Thomas Monjalon [this message]
2016-07-06 11:09 ` [dpdk-dev] [PATCH 3/3] scripts: check headline of drivers commits Bruce Richardson
2016-07-06 12:36 ` Thomas Monjalon
2016-07-06 11:59 ` Nélio Laranjeiro
2016-07-06 13:15 ` Thomas Monjalon
2016-07-06 13:41 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-07-10 14:37 ` [dpdk-dev] [PATCH 0/3] more commits checks Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467801530-20800-4-git-send-email-thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).