From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org, huilongx.xu@intel.com, waterman.cao@intel.com,
yuanhan.liu@intel.com, weichunx.chen@intel.com,
yu.y.liu@intel.com
Cc: thomas.monjalon@6wind.com
Subject: [dpdk-dev] [PATCH 2/4] mbuf: set errno on pool creation error
Date: Mon, 11 Jul 2016 12:20:26 +0200 [thread overview]
Message-ID: <1468232428-24088-3-git-send-email-olivier.matz@6wind.com> (raw)
In-Reply-To: <1468232428-24088-1-git-send-email-olivier.matz@6wind.com>
In rte_pktmbuf_pool_create(), the rte_errno variable was not always
set on failure.
Fixes: 152ca517900b ("mbuf: use default mempool handler from config")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_mbuf/rte_mbuf.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index 601e528..4846b89 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -156,6 +156,7 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,
struct rte_mempool *mp;
struct rte_pktmbuf_pool_private mbp_priv;
unsigned elt_size;
+ int ret;
if (RTE_ALIGN(priv_size, RTE_MBUF_PRIV_ALIGN) != priv_size) {
RTE_LOG(ERR, MBUF, "mbuf priv_size=%u is not aligned\n",
@@ -181,8 +182,10 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,
}
rte_pktmbuf_pool_init(mp, &mbp_priv);
- if (rte_mempool_populate_default(mp) < 0) {
+ ret = rte_mempool_populate_default(mp);
+ if (ret < 0) {
rte_mempool_free(mp);
+ rte_errno = -ret;
return NULL;
}
--
2.8.1
next prev parent reply other threads:[~2016-07-11 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 10:20 [dpdk-dev] [PATCH 0/4] fix mempool creation with Xen Dom0 Olivier Matz
2016-07-11 10:20 ` [dpdk-dev] [PATCH 1/4] eal: fix typo in Xen Dom0 specific code Olivier Matz
2016-07-11 10:20 ` Olivier Matz [this message]
2016-07-11 10:20 ` [dpdk-dev] [PATCH 3/4] eal: fix retrieval of phys address with Xen Dom0 Olivier Matz
2016-07-11 10:20 ` [dpdk-dev] [PATCH 4/4] mempool: fix creation " Olivier Matz
2016-07-11 16:23 ` [dpdk-dev] [PATCH 0/4] fix mempool " Olivier Matz
2016-07-11 17:09 ` Thomas Monjalon
2016-07-12 0:31 ` Chen, WeichunX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468232428-24088-3-git-send-email-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=huilongx.xu@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=waterman.cao@intel.com \
--cc=weichunx.chen@intel.com \
--cc=yu.y.liu@intel.com \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).