From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id C20F55A72 for ; Fri, 10 Jul 2015 12:28:58 +0200 (CEST) Received: by wifm2 with SMTP id m2so42404886wif.1 for ; Fri, 10 Jul 2015 03:28:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8pqwfGIgaP5uRI0eKyT5rhriSQ61ogsVpFk9dCBABsc=; b=ewdyAgYFaRMCur+n6AskhOHx/mRAkl1xzBxIDJlqUtFFehmxjXd6VkPLPWnovHVm1d FRXy+5qGs+bSNGcqMeh7SBkjBzvOa+Po35O+MYbxdbGNzbm3pJZxjbI/exYwjCtRmPZ5 ekSHuix8EoPGMY6bBaLo4INhK+nDEwJ6woh/REQqRzaQ7fOnuWDQaup1W8E7i1/u1+XH 5C4y3DKw6mBnFSea1QsvdhhXZukcdFshE5yPJf73hvFug/OSi2n81G2uSajTjUInarOL xeUQz6eBgphVaZlI/iH9wAv0wwbZxrZvyLkBE1AyAxQ6fi7Ax0OKJpHMcCLUmH8mqd7i E3Kw== X-Gm-Message-State: ALoCoQm8Ji1UUwDVMtgjT1b+j/ErIaL0CgbuB0ReZxQX/imXpjEwaGLmwayvUngOC0xTyrGH82Eg X-Received: by 10.180.86.6 with SMTP id l6mr4794933wiz.91.1436524138639; Fri, 10 Jul 2015 03:28:58 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id di9sm2248989wib.16.2015.07.10.03.28.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jul 2015 03:28:57 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Fri, 10 Jul 2015 12:27:50 +0200 Message-ID: <1468321.xAuDIq3Hpb@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150708132142.GB5708@bricha3-MOBL3> References: <1436354854-30700-1-git-send-email-pablo.de.lara.guarch@intel.com> <1436354854-30700-2-git-send-email-pablo.de.lara.guarch@intel.com> <20150708132142.GB5708@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] hash: move rte_hash structure to C file and make it internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 10:28:59 -0000 2015-07-08 14:21, Bruce Richardson: > On Wed, Jul 08, 2015 at 12:27:34PM +0100, Pablo de Lara wrote: > > rte_hash structure should not be a public structure, > > and therefore it should be moved to the C file and be declared > > as internal. rte_hash_hash implementation is also moved > > to the C file, as it uses the structure. > > > > This patch also removes part of a unit test that was checking > > a field of the structure. > > > > Signed-off-by: Pablo de Lara > > Irrespective of whether or not we change the underlying hash table implementation > this looks a good change to me. The rte_hash structure should not be used directly > by any applications - the APIs all take pointers to the structure, > so there should be no ABI breakage from this, I think. > > Therefore: > > Acked-by: Bruce Richardson Applied, thanks