From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id 75A1A9E7 for ; Fri, 15 Jul 2016 20:33:44 +0200 (CEST) Received: by mail-qk0-f195.google.com with SMTP id p126so1685932qke.1 for ; Fri, 15 Jul 2016 11:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=B7GyYBC3/6pm+NWm1rci/8yKjCrtjQh9tJ6MKz6gJDY=; b=M3Y2K9wTfQGemsSvqt3F7aeSGmJIV8F0smSjeiMD7eg6IydfEbLroXPOwj1+Xl6vK3 lN6eTmkeI3QbwaHU55pKAtImFz2ZcxLoNgYicyoftBQ94TpD03EDTdrUUcCfSLExGSjg JuuytxAhTKERNrXQYvNmcN1GSe8rQHa3+tLP6fV8cDx1wB7RON+7kvLlbcRH6iwgSVt9 Qhrmb0dSTTV6cONFzmJgh2VS+jRLrB8Cx6mKIjZeyEQF4mPK4+/JYLMIGv3o/ZLUGk9+ uUkkOuNE0w7e154MlN+kRhqoLQn4fR5u/OMER6VVdKJ/Qf9NJfGN5pqosE9cpkOCz4WW J1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=B7GyYBC3/6pm+NWm1rci/8yKjCrtjQh9tJ6MKz6gJDY=; b=JtxRJbc3AdzPVcCxPkUNLoM2cR+JDQiUymxyqZjsfjXoTgdlWFJmB0A1qZ/tKT3neJ M81iquizAGf7aJH4RB9xD6MsfoBzk+fr5goRW6Tl0eYUFOXU5vUZKMXrQ0HbQ9Ypxj5X z3QwsymphqiLxIJ13otJHrhB7QCHQScJ+kN2bt/GQLJp4SixYdYr7wzedx2Qf25ae87S k8wHjk1pPzFtCHB2IwdCNPzB475Ip+bGaYKO1prgYDrP+g38toMBqQSIfcenu3PnRh4T 7uXisme9N6uGihgvcVojbKNSuAZAhxhAOqGsJbXBrNElbqp/6fqVYgJfHiNBsLMErwtX sAAg== X-Gm-Message-State: ALyK8tLwLDVrxOenpe83ceHcBnkMAv/V6626Pzh6u4gc25/lRila7GEdXpezw3ZtuXk1AA== X-Received: by 10.55.197.149 with SMTP id k21mr26952139qkl.89.1468607623962; Fri, 15 Jul 2016 11:33:43 -0700 (PDT) Received: from monolith.home (pool-173-79-169-182.washdc.fios.verizon.net. [173.79.169.182]) by smtp.googlemail.com with ESMTPSA id m10sm2267769qta.31.2016.07.15.11.33.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jul 2016 11:33:43 -0700 (PDT) Message-ID: <1468607622.1732.4.camel@gmail.com> From: Chas Williams <3chas3@gmail.com> To: Bruce Richardson Cc: dev@dpdk.org, harish.patil@qlogic.com Date: Fri, 15 Jul 2016 14:33:42 -0400 In-Reply-To: <20160715155615.GB51144@bricha3-MOBL3> References: <1468330694-383-2-git-send-email-3chas3@gmail.com> <20160715155615.GB51144@bricha3-MOBL3> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 02/10] bnx2x: Remove unused preprocessor symbols and code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 18:33:44 -0000 On Fri, 2016-07-15 at 16:56 +0100, Bruce Richardson wrote: > On Tue, Jul 12, 2016 at 09:38:06AM -0400, Chas Williams wrote: > > ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined.  Remove them > > along with enumeration constants dependent on their inclusion. > >  > > Fixes: 540a211084a7 ("bnx2x: driver core") > >  > > Signed-off-by: Chas Williams <3chas3@gmail.com> > > Hi Chas, > > the threading on this submission is very awkward - poor patch 1 got somehow > separated from the rest of it's patch family. :-) Yeah, I don't know what happened there. > Besides this, given where we are in the release cycle for 16.07, these cleanups > are being deferred for possible inclusion in 16.11 (once reviewed and acked, > obviously). To get cleanup like this in in future release, please submit by > the integration deadline date. Not a problem.  These are not urgent changes.  There are some real issues fixed but I suspect no one runs into them.