From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: huawei.xie@intel.com, yuanhan.liu@linux.intel.com
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH] net: virtio: clear reserved vring properly at setup time
Date: Mon, 18 Jul 2016 19:09:24 +0200 [thread overview]
Message-ID: <1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com> (raw)
After vring reservation, only the first bytes of the vring were
cleared.
This patch fixes this to clear the real size fo the vring.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
Note: I found this bug while doing some code review, it is not a fix for
a problem I encountered.
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 850e3ba..336b3fc 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -387,7 +387,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
}
}
- memset(mz->addr, 0, sizeof(mz->len));
+ memset(mz->addr, 0, mz->len);
vq->vq_ring_mem = mz->phys_addr;
vq->vq_ring_virt_mem = mz->addr;
--
2.7.4
next reply other threads:[~2016-07-18 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 17:09 Maxime Coquelin [this message]
2016-07-19 1:39 ` Yuanhan Liu
2016-07-19 5:31 ` Maxime Coquelin
2016-07-19 5:39 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).