From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 788472B9D for ; Mon, 18 Jul 2016 20:15:32 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 18 Jul 2016 11:15:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,385,1464678000"; d="scan'208";a="736215635" Received: from unknown (HELO localhost.ch.intel.com) ([10.2.63.143]) by FMSMGA003.fm.intel.com with ESMTP; 18 Jul 2016 11:15:33 -0700 From: "Chokkalingam, SankarX" To: dev@dpdk.org Cc: cristian.dumitrescu@intel.com Date: Mon, 18 Jul 2016 11:15:43 -0700 Message-Id: <1468865743-2108-1-git-send-email-sankarx.chokkalingam@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH] ip_pipeline: Fix for Flow Classifcation IPv6 configuration error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 18:15:32 -0000 IP Pipeline application with the configuration for Flow Classification IPV6 did not instantiate. Parse error in section "PIPELINE1": entry "dma_src_mask" too long The dma_src_mask check in pipeline_passthrough_parse_args() is wrong. This fix increases the length of dma_src_mask by 1 for NULL termination and corrected the validation of dma_src_mask length. This fix is also propagated to pipeline_fc_parse_args() for key_mask_str validation. Signed-off-by: Chokkalingam, SankarX Acked-by: Cristian Dumitrescu --- examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c | 6 +++--- examples/ip_pipeline/pipeline/pipeline_passthrough_be.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c b/examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c index 8a762bc..026f00c 100644 --- a/examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c +++ b/examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c @@ -221,7 +221,7 @@ pipeline_fc_parse_args(struct pipeline_flow_classification *p, uint32_t flow_id_offset_present = 0; uint32_t i; - char key_mask_str[PIPELINE_FC_FLOW_KEY_MAX_SIZE * 2]; + char key_mask_str[PIPELINE_FC_FLOW_KEY_MAX_SIZE * 2 + 1]; p->hash_offset = 0; @@ -303,13 +303,13 @@ pipeline_fc_parse_args(struct pipeline_flow_classification *p, params->name, arg_name); key_mask_present = 1; - PIPELINE_ARG_CHECK((mask_str_len < + PIPELINE_ARG_CHECK((mask_str_len <= (PIPELINE_FC_FLOW_KEY_MAX_SIZE * 2)), "Parse error in section \"%s\": entry " "\"%s\" is too long", params->name, arg_name); - snprintf(key_mask_str, sizeof(key_mask_str), "%s", + snprintf(key_mask_str, mask_str_len + 1, "%s", arg_value); continue; diff --git a/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c b/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c index 6146a28..356f02d 100644 --- a/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c +++ b/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c @@ -366,7 +366,7 @@ pipeline_passthrough_parse_args(struct pipeline_passthrough_params *p, uint32_t dma_hash_offset_present = 0; uint32_t lb_present = 0; uint32_t i; - char dma_mask_str[PIPELINE_PASSTHROUGH_DMA_SIZE_MAX * 2]; + char dma_mask_str[PIPELINE_PASSTHROUGH_DMA_SIZE_MAX * 2 + 1]; /* default values */ p->dma_enabled = 0; @@ -454,7 +454,7 @@ pipeline_passthrough_parse_args(struct pipeline_passthrough_params *p, params->name, arg_name); dma_src_mask_present = 1; - PIPELINE_ARG_CHECK((mask_str_len < + PIPELINE_ARG_CHECK((mask_str_len <= (PIPELINE_PASSTHROUGH_DMA_SIZE_MAX * 2)), "Parse error in section \"%s\": entry " "\"%s\" too long", params->name, -- 2.5.5