DPDK patches and discussions
 help / color / mirror / Atom feed
From: Zoltan Kiss <zoltan.kiss@schaman.hu>
To: dev@dpdk.org
Cc: David Hunt <david.hunt@intel.com>,
	olivier.matz@6wind.com,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: [dpdk-dev] [PATCH v2] mempool: fix lack of free registration
Date: Wed, 20 Jul 2016 18:14:00 +0100	[thread overview]
Message-ID: <1469034842-2580-1-git-send-email-zoltan.kiss@schaman.hu> (raw)
In-Reply-To: <1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu>

The new mempool handler interface forgets to register the free() function
of the ops. Introduced in this patch:

Fixes: 449c49b93a6b ("mempool: support handler operations")

Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---

Notes:
    v2: fix commit message

 lib/librte_mempool/rte_mempool_ops.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c
index fd0b64c..5f24de2 100644
--- a/lib/librte_mempool/rte_mempool_ops.c
+++ b/lib/librte_mempool/rte_mempool_ops.c
@@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h)
 	ops = &rte_mempool_ops_table.ops[ops_index];
 	snprintf(ops->name, sizeof(ops->name), "%s", h->name);
 	ops->alloc = h->alloc;
+	ops->free = h->free;
 	ops->enqueue = h->enqueue;
 	ops->dequeue = h->dequeue;
 	ops->get_count = h->get_count;
-- 
1.9.1

  parent reply	other threads:[~2016-07-20 17:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 14:37 [dpdk-dev] [PATCH] mempool: fix lack of free() registration Zoltan Kiss
2016-07-19 14:37 ` [dpdk-dev] [PATCH] mempool: adjust name string size in related data types Zoltan Kiss
2016-07-19 15:37   ` Olivier Matz
2016-07-19 15:59     ` Zoltan Kiss
2016-07-19 16:17       ` Olivier Matz
2016-07-20 12:41         ` Zoltan Kiss
2016-07-20 13:37           ` Olivier Matz
2016-07-20 14:01             ` Richardson, Bruce
2016-07-20 17:20             ` Zoltan Kiss
2016-07-20 17:16   ` [dpdk-dev] [PATCH v2] " Zoltan Kiss
2016-07-21 13:40     ` Olivier Matz
2016-07-21 13:47       ` Zoltan Kiss
2016-07-21 14:25         ` Olivier Matz
2016-07-21 21:16           ` Thomas Monjalon
2016-07-19 15:26 ` [dpdk-dev] [PATCH] mempool: fix lack of free() registration Olivier Matz
2016-07-19 16:17   ` Zoltan Kiss
2016-07-20 17:14 ` Zoltan Kiss [this message]
2016-07-21 21:04   ` [dpdk-dev] [PATCH v2] mempool: fix lack of free registration Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469034842-2580-1-git-send-email-zoltan.kiss@schaman.hu \
    --to=zoltan.kiss@schaman.hu \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).