* [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver
@ 2016-08-18 13:34 Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-08-18 13:34 UTC (permalink / raw)
To: pablo.de.lara.guarch, fiona.trahe, john.griffin; +Cc: dev, Deepak Kumar Jain
This patchset adds support of NULL crypto in Intel(R) QuickAssist Technology driver.
This patchset depends on following patchset:
"crypto/qat: add aes-sha384-hmac capability to Intel QAT driver"
(http://dpdk.org/dev/patchwork/patch/15228/)
Deepak Kumar Jain (2):
crypto/qat: add NULL capability to Intel QAT driver
app/test: add test cases for NULL for Intel QAT driver
app/test/test_cryptodev.c | 10 ++++++++++
doc/guides/cryptodevs/qat.rst | 3 ++-
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 4 ++++
4 files changed, 18 insertions(+), 1 deletion(-)
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH 1/2] crypto/qat: add NULL capability to Intel QAT driver
2016-08-18 13:34 [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver Deepak Kumar Jain
@ 2016-08-18 13:34 ` Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-08-18 13:34 UTC (permalink / raw)
To: pablo.de.lara.guarch, fiona.trahe, john.griffin; +Cc: dev, Deepak Kumar Jain
enabled NULL crypto for Intel(R) QuickAssist Technology
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
doc/guides/cryptodevs/qat.rst | 3 ++-
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 4 ++++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 78a734f..bb62f22 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -49,6 +49,7 @@ Cipher algorithms:
* ``RTE_CRYPTO_SYM_CIPHER_AES256_CTR``
* ``RTE_CRYPTO_SYM_CIPHER_SNOW3G_UEA2``
* ``RTE_CRYPTO_CIPHER_AES_GCM``
+* ``RTE_CRYPTO_CIPHER_NULL``
Hash algorithms:
@@ -60,7 +61,7 @@ Hash algorithms:
* ``RTE_CRYPTO_AUTH_AES_XCBC_MAC``
* ``RTE_CRYPTO_AUTH_SNOW3G_UIA2``
* ``RTE_CRYPTO_AUTH_MD5_HMAC``
-
+* ``RTE_CRYPTO_AUTH_NULL``
Limitations
-----------
diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
index af8c176..d9437bc 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
@@ -720,6 +720,8 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
}
state2_size = ICP_QAT_HW_MD5_STATE2_SZ;
break;
+ case ICP_QAT_HW_AUTH_ALGO_NULL:
+ break;
default:
PMD_DRV_LOG(ERR, "Invalid HASH alg %u", cdesc->qat_hash_alg);
return -EFAULT;
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index a474512..434ff81 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -427,6 +427,8 @@ qat_crypto_sym_configure_session_cipher(struct rte_cryptodev *dev,
session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
break;
case RTE_CRYPTO_CIPHER_NULL:
+ session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
+ break;
case RTE_CRYPTO_CIPHER_3DES_ECB:
case RTE_CRYPTO_CIPHER_3DES_CBC:
case RTE_CRYPTO_CIPHER_AES_ECB:
@@ -558,6 +560,8 @@ qat_crypto_sym_configure_session_auth(struct rte_cryptodev *dev,
session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_MD5;
break;
case RTE_CRYPTO_AUTH_NULL:
+ session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_NULL;
+ break;
case RTE_CRYPTO_AUTH_SHA1:
case RTE_CRYPTO_AUTH_SHA256:
case RTE_CRYPTO_AUTH_SHA512:
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH 2/2] app/test: add test cases for NULL for Intel QAT driver
2016-08-18 13:34 [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
@ 2016-08-18 13:34 ` Deepak Kumar Jain
2016-09-07 18:05 ` [dpdk-dev] [PATCH 0/2] add NULL crypto support in " De Lara Guarch, Pablo
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
3 siblings, 0 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-08-18 13:34 UTC (permalink / raw)
To: pablo.de.lara.guarch, fiona.trahe, john.griffin; +Cc: dev, Deepak Kumar Jain
Added NULL algorithm to test file for Intel(R) QuickAssist
Technology Driver
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
app/test/test_cryptodev.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 8553759..67ca912 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -4136,6 +4136,16 @@ static struct unit_test_suite cryptodev_qat_testsuite = {
TEST_CASE_ST(ut_setup, ut_teardown,
test_MD5_HMAC_verify_case_2),
+ /** NULL tests */
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_auth_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_cipher_operation),
+
TEST_CASES_END() /**< NULL terminate unit test array */
}
};
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver
2016-08-18 13:34 [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
@ 2016-09-07 18:05 ` De Lara Guarch, Pablo
2016-09-07 19:33 ` Jain, Deepak K
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
3 siblings, 1 reply; 18+ messages in thread
From: De Lara Guarch, Pablo @ 2016-09-07 18:05 UTC (permalink / raw)
To: Jain, Deepak K, Trahe, Fiona, Griffin, John; +Cc: dev
Hi Deepak,
> -----Original Message-----
> From: Jain, Deepak K
> Sent: Thursday, August 18, 2016 6:34 AM
> To: De Lara Guarch, Pablo; Trahe, Fiona; Griffin, John
> Cc: dev@dpdk.org; Jain, Deepak K
> Subject: [PATCH 0/2] add NULL crypto support in Intel QAT driver
>
> This patchset adds support of NULL crypto in Intel(R) QuickAssist Technology
> driver.
>
> This patchset depends on following patchset:
> "crypto/qat: add aes-sha384-hmac capability to Intel QAT driver"
> (http://dpdk.org/dev/patchwork/patch/15228/)
>
> Deepak Kumar Jain (2):
> crypto/qat: add NULL capability to Intel QAT driver
> app/test: add test cases for NULL for Intel QAT driver
>
> app/test/test_cryptodev.c | 10 ++++++++++
> doc/guides/cryptodevs/qat.rst | 3 ++-
> drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
> drivers/crypto/qat/qat_crypto.c | 4 ++++
> 4 files changed, 18 insertions(+), 1 deletion(-)
>
> --
> 2.5.5
Could you send a v2 with a release notes update?
Thanks,
Pablo
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver
2016-09-07 18:05 ` [dpdk-dev] [PATCH 0/2] add NULL crypto support in " De Lara Guarch, Pablo
@ 2016-09-07 19:33 ` Jain, Deepak K
0 siblings, 0 replies; 18+ messages in thread
From: Jain, Deepak K @ 2016-09-07 19:33 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Trahe, Fiona, Griffin, John; +Cc: dev
HI Pablo,
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, September 7, 2016 7:05 PM
> To: Jain, Deepak K <deepak.k.jain@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 0/2] add NULL crypto support in Intel QAT driver
>
> Hi Deepak,
>
> > -----Original Message-----
> > From: Jain, Deepak K
> > Sent: Thursday, August 18, 2016 6:34 AM
> > To: De Lara Guarch, Pablo; Trahe, Fiona; Griffin, John
> > Cc: dev@dpdk.org; Jain, Deepak K
> > Subject: [PATCH 0/2] add NULL crypto support in Intel QAT driver
> >
> > This patchset adds support of NULL crypto in Intel(R) QuickAssist
> > Technology driver.
> >
> > This patchset depends on following patchset:
> > "crypto/qat: add aes-sha384-hmac capability to Intel QAT driver"
> > (http://dpdk.org/dev/patchwork/patch/15228/)
> >
> > Deepak Kumar Jain (2):
> > crypto/qat: add NULL capability to Intel QAT driver
> > app/test: add test cases for NULL for Intel QAT driver
> >
> > app/test/test_cryptodev.c | 10 ++++++++++
> > doc/guides/cryptodevs/qat.rst | 3 ++-
> > drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
> > drivers/crypto/qat/qat_crypto.c | 4 ++++
> > 4 files changed, 18 insertions(+), 1 deletion(-)
> >
> > --
> > 2.5.5
>
> Could you send a v2 with a release notes update?
>
Agreed. I will send v2 with release notes.
> Thanks,
> Pablo
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v2 0/2] add NULL crypto support in Intel QAT driver
2016-08-18 13:34 [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver Deepak Kumar Jain
` (2 preceding siblings ...)
2016-09-07 18:05 ` [dpdk-dev] [PATCH 0/2] add NULL crypto support in " De Lara Guarch, Pablo
@ 2016-09-12 20:00 ` Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
` (3 more replies)
3 siblings, 4 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-12 20:00 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar Jain
This patchset adds support of NULL crypto in Intel(R) QuickAssist Technology driver.
This patchset depends on following patchset:
"crypto/qat: add aes-sha384-hmac capability to Intel QAT driver"
(http://dpdk.org/dev/patchwork/patch/15778/)
Deepak Kumar JAIN (2):
crypto/qat: add NULL capability to Intel QAT driver
app/test: add test cases for NULL for Intel QAT driver
Changes in V1:
* Added new feature information in release_16_11.rst file.
app/test/test_cryptodev.c | 10 ++++++++++
doc/guides/cryptodevs/qat.rst | 3 ++-
doc/guides/rel_notes/release_16_11.rst | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 4 ++++
5 files changed, 19 insertions(+), 1 deletion(-)
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] crypto/qat: add NULL capability to Intel QAT driver
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
@ 2016-09-12 20:00 ` Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-12 20:00 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar JAIN
From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
enabled NULL crypto for Intel(R) QuickAssist Technology
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
doc/guides/cryptodevs/qat.rst | 3 ++-
doc/guides/rel_notes/release_16_11.rst | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 4 ++++
4 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 78a734f..bb62f22 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -49,6 +49,7 @@ Cipher algorithms:
* ``RTE_CRYPTO_SYM_CIPHER_AES256_CTR``
* ``RTE_CRYPTO_SYM_CIPHER_SNOW3G_UEA2``
* ``RTE_CRYPTO_CIPHER_AES_GCM``
+* ``RTE_CRYPTO_CIPHER_NULL``
Hash algorithms:
@@ -60,7 +61,7 @@ Hash algorithms:
* ``RTE_CRYPTO_AUTH_AES_XCBC_MAC``
* ``RTE_CRYPTO_AUTH_SNOW3G_UIA2``
* ``RTE_CRYPTO_AUTH_MD5_HMAC``
-
+* ``RTE_CRYPTO_AUTH_NULL``
Limitations
-----------
diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 9b2f102..9b2c775 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -42,6 +42,7 @@ New Features
* Added support for MD5_HMAC algorithm.
* Added support for SHA224-HMAC algorithm.
* Added support for SHA384-HMAC algorithm.
+ * Added support for NULL algorithm.
Resolved Issues
diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
index af8c176..d9437bc 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
@@ -720,6 +720,8 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
}
state2_size = ICP_QAT_HW_MD5_STATE2_SZ;
break;
+ case ICP_QAT_HW_AUTH_ALGO_NULL:
+ break;
default:
PMD_DRV_LOG(ERR, "Invalid HASH alg %u", cdesc->qat_hash_alg);
return -EFAULT;
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 60e2ba2..be2b9be 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -469,6 +469,8 @@ qat_crypto_sym_configure_session_cipher(struct rte_cryptodev *dev,
session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
break;
case RTE_CRYPTO_CIPHER_NULL:
+ session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
+ break;
case RTE_CRYPTO_CIPHER_3DES_ECB:
case RTE_CRYPTO_CIPHER_3DES_CBC:
case RTE_CRYPTO_CIPHER_AES_ECB:
@@ -600,6 +602,8 @@ qat_crypto_sym_configure_session_auth(struct rte_cryptodev *dev,
session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_MD5;
break;
case RTE_CRYPTO_AUTH_NULL:
+ session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_NULL;
+ break;
case RTE_CRYPTO_AUTH_SHA1:
case RTE_CRYPTO_AUTH_SHA256:
case RTE_CRYPTO_AUTH_SHA512:
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] app/test: add test cases for NULL for Intel QAT driver
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
@ 2016-09-12 20:00 ` Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " Deepak Kumar Jain
3 siblings, 0 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-12 20:00 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar JAIN
From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
Added NULL algorithm to test file for Intel(R) QuickAssist
Technology Driver
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
app/test/test_cryptodev.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 8553759..67ca912 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -4136,6 +4136,16 @@ static struct unit_test_suite cryptodev_qat_testsuite = {
TEST_CASE_ST(ut_setup, ut_teardown,
test_MD5_HMAC_verify_case_2),
+ /** NULL tests */
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_auth_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_cipher_operation),
+
TEST_CASES_END() /**< NULL terminate unit test array */
}
};
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v3 0/2] add NULL crypto support in Intel QAT driver
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
@ 2016-09-13 8:59 ` Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " Deepak Kumar Jain
3 siblings, 2 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-13 8:59 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar Jain
This patchset adds support of NULL crypto in Intel(R) QuickAssist Technology driver.
This patchset depends on following patchset:
"crypto/qat: add aes-sha384-hmac capability to Intel QAT driver"
(http://dpdk.org/dev/patchwork/patch/15778/)
Deepak Kumar JAIN (2):
crypto/qat: add NULL capability to Intel QAT driver
app/test: add test cases for NULL for Intel QAT driver
Changes in v3:
* Added information in capability structure.
Changes in v2:
* Added new feature information in release_16_11.rst file.
app/test/test_cryptodev.c | 10 ++++++
doc/guides/cryptodevs/qat.rst | 3 +-
doc/guides/rel_notes/release_16_11.rst | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 45 ++++++++++++++++++++++++
5 files changed, 60 insertions(+), 1 deletion(-)
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to Intel QAT driver
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 0/2] add NULL crypto support in " Deepak Kumar Jain
@ 2016-09-13 8:59 ` Deepak Kumar Jain
2016-09-15 13:34 ` Trahe, Fiona
2016-09-16 1:43 ` De Lara Guarch, Pablo
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
1 sibling, 2 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-13 8:59 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar JAIN
From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
enabled NULL crypto for Intel(R) QuickAssist Technology
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
doc/guides/cryptodevs/qat.rst | 3 +-
doc/guides/rel_notes/release_16_11.rst | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 45 ++++++++++++++++++++++++
4 files changed, 50 insertions(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 78a734f..bb62f22 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -49,6 +49,7 @@ Cipher algorithms:
* ``RTE_CRYPTO_SYM_CIPHER_AES256_CTR``
* ``RTE_CRYPTO_SYM_CIPHER_SNOW3G_UEA2``
* ``RTE_CRYPTO_CIPHER_AES_GCM``
+* ``RTE_CRYPTO_CIPHER_NULL``
Hash algorithms:
@@ -60,7 +61,7 @@ Hash algorithms:
* ``RTE_CRYPTO_AUTH_AES_XCBC_MAC``
* ``RTE_CRYPTO_AUTH_SNOW3G_UIA2``
* ``RTE_CRYPTO_AUTH_MD5_HMAC``
-
+* ``RTE_CRYPTO_AUTH_NULL``
Limitations
-----------
diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 9b2f102..9b2c775 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -42,6 +42,7 @@ New Features
* Added support for MD5_HMAC algorithm.
* Added support for SHA224-HMAC algorithm.
* Added support for SHA384-HMAC algorithm.
+ * Added support for NULL algorithm.
Resolved Issues
diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
index af8c176..d9437bc 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
@@ -720,6 +720,8 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
}
state2_size = ICP_QAT_HW_MD5_STATE2_SZ;
break;
+ case ICP_QAT_HW_AUTH_ALGO_NULL:
+ break;
default:
PMD_DRV_LOG(ERR, "Invalid HASH alg %u", cdesc->qat_hash_alg);
return -EFAULT;
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 60e2ba2..bc8d5b1 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -346,6 +346,47 @@ static const struct rte_cryptodev_capabilities qat_pmd_capabilities[] = {
}, }
}, }
},
+ { /* NULL (AUTH) */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+ {.auth = {
+ .algo = RTE_CRYPTO_AUTH_NULL,
+ .block_size = 1,
+ .key_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 0
+ },
+ .digest_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 0
+ },
+ .aad_size = { 0 }
+ }, },
+ }, },
+ },
+ { /* NULL (CIPHER) */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+ {.cipher = {
+ .algo = RTE_CRYPTO_CIPHER_NULL,
+ .block_size = 1,
+ .key_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 8
+ },
+ .iv_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 0
+ }
+ }, },
+ }, }
+ },
RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
};
@@ -469,6 +510,8 @@ qat_crypto_sym_configure_session_cipher(struct rte_cryptodev *dev,
session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
break;
case RTE_CRYPTO_CIPHER_NULL:
+ session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
+ break;
case RTE_CRYPTO_CIPHER_3DES_ECB:
case RTE_CRYPTO_CIPHER_3DES_CBC:
case RTE_CRYPTO_CIPHER_AES_ECB:
@@ -600,6 +643,8 @@ qat_crypto_sym_configure_session_auth(struct rte_cryptodev *dev,
session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_MD5;
break;
case RTE_CRYPTO_AUTH_NULL:
+ session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_NULL;
+ break;
case RTE_CRYPTO_AUTH_SHA1:
case RTE_CRYPTO_AUTH_SHA256:
case RTE_CRYPTO_AUTH_SHA512:
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for Intel QAT driver
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
@ 2016-09-13 8:59 ` Deepak Kumar Jain
2016-09-15 13:48 ` Trahe, Fiona
1 sibling, 1 reply; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-13 8:59 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar JAIN
From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
Added NULL algorithm to test file for Intel(R) QuickAssist
Technology Driver
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
---
app/test/test_cryptodev.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 8553759..67ca912 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -4136,6 +4136,16 @@ static struct unit_test_suite cryptodev_qat_testsuite = {
TEST_CASE_ST(ut_setup, ut_teardown,
test_MD5_HMAC_verify_case_2),
+ /** NULL tests */
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_auth_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_cipher_operation),
+
TEST_CASES_END() /**< NULL terminate unit test array */
}
};
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to Intel QAT driver
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
@ 2016-09-15 13:34 ` Trahe, Fiona
2016-09-16 1:43 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 18+ messages in thread
From: Trahe, Fiona @ 2016-09-15 13:34 UTC (permalink / raw)
To: Jain, Deepak K, dev; +Cc: De Lara Guarch, Pablo, Trahe, Fiona
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Deepak Kumar Jain
> Sent: Tuesday, September 13, 2016 9:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>
> Subject: [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to Intel
> QAT driver
>
> From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
>
> enabled NULL crypto for Intel(R) QuickAssist Technology
>
> Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for Intel QAT driver
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
@ 2016-09-15 13:48 ` Trahe, Fiona
0 siblings, 0 replies; 18+ messages in thread
From: Trahe, Fiona @ 2016-09-15 13:48 UTC (permalink / raw)
To: Jain, Deepak K, dev; +Cc: De Lara Guarch, Pablo, Trahe, Fiona
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Deepak Kumar Jain
> Sent: Tuesday, September 13, 2016 9:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>
> Subject: [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for Intel
> QAT driver
>
> From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
>
> Added NULL algorithm to test file for Intel(R) QuickAssist Technology Driver
>
> Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to Intel QAT driver
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-15 13:34 ` Trahe, Fiona
@ 2016-09-16 1:43 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 18+ messages in thread
From: De Lara Guarch, Pablo @ 2016-09-16 1:43 UTC (permalink / raw)
To: Jain, Deepak K, dev
Hi Deepak,
> -----Original Message-----
> From: Jain, Deepak K
> Sent: Tuesday, September 13, 2016 1:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Jain, Deepak K
> Subject: [PATCH v3 1/2] crypto/qat: add NULL capability to Intel QAT driver
>
> From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
>
> enabled NULL crypto for Intel(R) QuickAssist Technology
>
> Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 3 +-
> doc/guides/rel_notes/release_16_11.rst | 1 +
> drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
> drivers/crypto/qat/qat_crypto.c | 45 ++++++++++++++++++++++++
> 4 files changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index 78a734f..bb62f22 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -49,6 +49,7 @@ Cipher algorithms:
> * ``RTE_CRYPTO_SYM_CIPHER_AES256_CTR``
> * ``RTE_CRYPTO_SYM_CIPHER_SNOW3G_UEA2``
> * ``RTE_CRYPTO_CIPHER_AES_GCM``
> +* ``RTE_CRYPTO_CIPHER_NULL``
>
> Hash algorithms:
>
> @@ -60,7 +61,7 @@ Hash algorithms:
> * ``RTE_CRYPTO_AUTH_AES_XCBC_MAC``
> * ``RTE_CRYPTO_AUTH_SNOW3G_UIA2``
> * ``RTE_CRYPTO_AUTH_MD5_HMAC``
> -
> +* ``RTE_CRYPTO_AUTH_NULL``
Extra blank line should remain here.
>
> Limitations
> -----------
...
> --- a/drivers/crypto/qat/qat_crypto.c
> +++ b/drivers/crypto/qat/qat_crypto.c
> @@ -346,6 +346,47 @@ static const struct rte_cryptodev_capabilities
> qat_pmd_capabilities[] = {
> }, }
> }, }
> },
> + { /* NULL (AUTH) */
> + .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> + {.sym = {
> + .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> + {.auth = {
> + .algo = RTE_CRYPTO_AUTH_NULL,
> + .block_size = 1,
> + .key_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 0
> + },
> + .digest_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 0
> + },
> + .aad_size = { 0 }
> + }, },
> + }, },
> + },
> + { /* NULL (CIPHER) */
> + .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> + {.sym = {
> + .xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
> + {.cipher = {
> + .algo = RTE_CRYPTO_CIPHER_NULL,
> + .block_size = 1,
> + .key_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 8
Increment should be 0, right?
> + },
> + .iv_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 0
> + }
> + }, },
> + }, }
> + },
> RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
> };
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in Intel QAT driver
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
` (2 preceding siblings ...)
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 0/2] add NULL crypto support in " Deepak Kumar Jain
@ 2016-09-16 8:57 ` Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
` (2 more replies)
3 siblings, 3 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-16 8:57 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar Jain
This patchset adds support of NULL crypto in Intel(R) QuickAssist Technology driver.
This patchset depends on following patchset:
"crypto/qat: add aes-sha384-hmac capability to Intel QAT driver"
(http://dpdk.org/dev/patchwork/patch/15778/)
Deepak Kumar JAIN (2):
crypto/qat: add NULL capability to Intel QAT driver
app/test: add test cases for NULL for Intel QAT driver
Changes in v4:
* Correct increment of key size in capabilities.
Changes in v3:
* Added information in capability structure.
Changes in v2:
* Added new feature information in release_16_11.rst file.
app/test/test_cryptodev.c | 10 ++++++
doc/guides/cryptodevs/qat.rst | 3 +-
doc/guides/rel_notes/release_16_11.rst | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 45 ++++++++++++++++++++++++
5 files changed, 60 insertions(+), 1 deletion(-)
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v4 1/2] crypto/qat: add NULL capability to Intel QAT driver
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " Deepak Kumar Jain
@ 2016-09-16 8:57 ` Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-16 21:54 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " De Lara Guarch, Pablo
2 siblings, 0 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-16 8:57 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar JAIN
From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
enabled NULL crypto for Intel(R) QuickAssist Technology
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
doc/guides/cryptodevs/qat.rst | 3 +-
doc/guides/rel_notes/release_16_11.rst | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
drivers/crypto/qat/qat_crypto.c | 45 ++++++++++++++++++++++++
4 files changed, 50 insertions(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 78a734f..bb62f22 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -49,6 +49,7 @@ Cipher algorithms:
* ``RTE_CRYPTO_SYM_CIPHER_AES256_CTR``
* ``RTE_CRYPTO_SYM_CIPHER_SNOW3G_UEA2``
* ``RTE_CRYPTO_CIPHER_AES_GCM``
+* ``RTE_CRYPTO_CIPHER_NULL``
Hash algorithms:
@@ -60,7 +61,7 @@ Hash algorithms:
* ``RTE_CRYPTO_AUTH_AES_XCBC_MAC``
* ``RTE_CRYPTO_AUTH_SNOW3G_UIA2``
* ``RTE_CRYPTO_AUTH_MD5_HMAC``
-
+* ``RTE_CRYPTO_AUTH_NULL``
Limitations
-----------
diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 9b2f102..9b2c775 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -42,6 +42,7 @@ New Features
* Added support for MD5_HMAC algorithm.
* Added support for SHA224-HMAC algorithm.
* Added support for SHA384-HMAC algorithm.
+ * Added support for NULL algorithm.
Resolved Issues
diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
index af8c176..d9437bc 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
@@ -720,6 +720,8 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
}
state2_size = ICP_QAT_HW_MD5_STATE2_SZ;
break;
+ case ICP_QAT_HW_AUTH_ALGO_NULL:
+ break;
default:
PMD_DRV_LOG(ERR, "Invalid HASH alg %u", cdesc->qat_hash_alg);
return -EFAULT;
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 60e2ba2..67af596 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -346,6 +346,47 @@ static const struct rte_cryptodev_capabilities qat_pmd_capabilities[] = {
}, }
}, }
},
+ { /* NULL (AUTH) */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+ {.auth = {
+ .algo = RTE_CRYPTO_AUTH_NULL,
+ .block_size = 1,
+ .key_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 0
+ },
+ .digest_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 0
+ },
+ .aad_size = { 0 }
+ }, },
+ }, },
+ },
+ { /* NULL (CIPHER) */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+ {.cipher = {
+ .algo = RTE_CRYPTO_CIPHER_NULL,
+ .block_size = 1,
+ .key_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 0
+ },
+ .iv_size = {
+ .min = 0,
+ .max = 0,
+ .increment = 0
+ }
+ }, },
+ }, }
+ },
RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
};
@@ -469,6 +510,8 @@ qat_crypto_sym_configure_session_cipher(struct rte_cryptodev *dev,
session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
break;
case RTE_CRYPTO_CIPHER_NULL:
+ session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
+ break;
case RTE_CRYPTO_CIPHER_3DES_ECB:
case RTE_CRYPTO_CIPHER_3DES_CBC:
case RTE_CRYPTO_CIPHER_AES_ECB:
@@ -600,6 +643,8 @@ qat_crypto_sym_configure_session_auth(struct rte_cryptodev *dev,
session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_MD5;
break;
case RTE_CRYPTO_AUTH_NULL:
+ session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_NULL;
+ break;
case RTE_CRYPTO_AUTH_SHA1:
case RTE_CRYPTO_AUTH_SHA256:
case RTE_CRYPTO_AUTH_SHA512:
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v4 2/2] app/test: add test cases for NULL for Intel QAT driver
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
@ 2016-09-16 8:57 ` Deepak Kumar Jain
2016-09-16 21:54 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " De Lara Guarch, Pablo
2 siblings, 0 replies; 18+ messages in thread
From: Deepak Kumar Jain @ 2016-09-16 8:57 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, Deepak Kumar JAIN
From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
Added NULL algorithm to test file for Intel(R) QuickAssist
Technology Driver
Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
app/test/test_cryptodev.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 8553759..67ca912 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -4136,6 +4136,16 @@ static struct unit_test_suite cryptodev_qat_testsuite = {
TEST_CASE_ST(ut_setup, ut_teardown,
test_MD5_HMAC_verify_case_2),
+ /** NULL tests */
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_only_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_cipher_auth_operation),
+ TEST_CASE_ST(ut_setup, ut_teardown,
+ test_null_auth_cipher_operation),
+
TEST_CASES_END() /**< NULL terminate unit test array */
}
};
--
2.5.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in Intel QAT driver
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
@ 2016-09-16 21:54 ` De Lara Guarch, Pablo
2 siblings, 0 replies; 18+ messages in thread
From: De Lara Guarch, Pablo @ 2016-09-16 21:54 UTC (permalink / raw)
To: Jain, Deepak K, dev
> -----Original Message-----
> From: Jain, Deepak K
> Sent: Friday, September 16, 2016 1:57 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Jain, Deepak K
> Subject: [PATCH v4 0/2] add NULL crypto support in Intel QAT driver
>
> This patchset adds support of NULL crypto in Intel(R) QuickAssist Technology
> driver.
>
> This patchset depends on following patchset:
> "crypto/qat: add aes-sha384-hmac capability to Intel QAT driver"
> (http://dpdk.org/dev/patchwork/patch/15778/)
>
> Deepak Kumar JAIN (2):
> crypto/qat: add NULL capability to Intel QAT driver
> app/test: add test cases for NULL for Intel QAT driver
>
> Changes in v4:
> * Correct increment of key size in capabilities.
>
> Changes in v3:
> * Added information in capability structure.
>
> Changes in v2:
> * Added new feature information in release_16_11.rst file.
>
> app/test/test_cryptodev.c | 10 ++++++
> doc/guides/cryptodevs/qat.rst | 3 +-
> doc/guides/rel_notes/release_16_11.rst | 1 +
> drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
> drivers/crypto/qat/qat_crypto.c | 45 ++++++++++++++++++++++++
> 5 files changed, 60 insertions(+), 1 deletion(-)
>
> --
> 2.5.5
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-09-16 21:54 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 13:34 [dpdk-dev] [PATCH 0/2] add NULL crypto support in Intel QAT driver Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-07 18:05 ` [dpdk-dev] [PATCH 0/2] add NULL crypto support in " De Lara Guarch, Pablo
2016-09-07 19:33 ` Jain, Deepak K
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-15 13:34 ` Trahe, Fiona
2016-09-16 1:43 ` De Lara Guarch, Pablo
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-15 13:48 ` Trahe, Fiona
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-16 21:54 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).