From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 5653D5A9F
for <dev@dpdk.org>; Fri, 26 Aug 2016 13:24:43 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga102.jf.intel.com with ESMTP; 26 Aug 2016 04:24:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,580,1464678000"; d="scan'208";a="1041865301"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
by orsmga002.jf.intel.com with ESMTP; 26 Aug 2016 04:24:41 -0700
Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com
[10.237.217.46])
by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
u7QBOe3I031334 for <dev@dpdk.org>; Fri, 26 Aug 2016 12:24:40 +0100
Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1])
by sivswdev02.ir.intel.com with ESMTP id u7QBOeta008989
for <dev@dpdk.org>; Fri, 26 Aug 2016 12:24:40 +0100
Received: (from fyigit@localhost)
by sivswdev02.ir.intel.com with id u7QBOeBL008985
for dev@dpdk.org; Fri, 26 Aug 2016 12:24:40 +0100
X-Authentication-Warning: sivswdev02.ir.intel.com: fyigit set sender to
ferruh.yigit@intel.com using -f
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org
Date: Fri, 26 Aug 2016 12:17:56 +0100
Message-Id: <1472210279-8286-20-git-send-email-ferruh.yigit@intel.com>
X-Mailer: git-send-email 1.7.4.1
In-Reply-To: <1472210279-8286-1-git-send-email-ferruh.yigit@intel.com>
References: <1472210279-8286-1-git-send-email-ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 19/22] net/pcap: fix missing Tx iface assignment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Aug 2016 11:24:43 -0000
Missing pcap assignment may cause pcap opened again, and previous one
not closed at all.
Fixes: 1e38a7c66923 ("pcap: fix storage of name and type in queues")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/pcap/rte_eth_pcap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 021425f..5a2a194 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -883,6 +883,7 @@ rte_eth_from_pcaps_common(const char *name, struct pmd_devargs *rx_queues,
struct devargs_queue *queue = &tx_queues->queue[i];
tx->dumper = queue->dumper;
+ tx->pcap = queue->pcap;
snprintf(tx->name, sizeof(tx->name), "%s", queue->name);
snprintf(tx->type, sizeof(tx->type), "%s", queue->type);
}
--
2.7.4