DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yong Wang <yongwang@vmware.com>
To: <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <gyang@vmware.com>, <diproiettod@vmware.com>,
	<jsnell@iki.fi>, Yong Wang <yongwang@vmware.com>
Subject: [dpdk-dev] [PATCH v3 6/6] net/vmxnet3: enable lro
Date: Mon, 29 Aug 2016 12:18:50 -0700	[thread overview]
Message-ID: <1472498330-18591-7-git-send-email-yongwang@vmware.com> (raw)
In-Reply-To: <1472498330-18591-1-git-send-email-yongwang@vmware.com>

The current implementation of jumbo frame rx can be used for
LRO directly without changes.  This change enables device
LRO if requested.

Note that since jumbo frame uses both ring0 and ring1, it
cannot be enabled in UPT (VMDirectPath) mode.

Signed-off-by: Yong Wang <yongwang@vmware.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
 doc/guides/nics/features/vmxnet3.ini | 1 +
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/features/vmxnet3.ini b/doc/guides/nics/features/vmxnet3.ini
index c5c75ad..ef95932 100644
--- a/doc/guides/nics/features/vmxnet3.ini
+++ b/doc/guides/nics/features/vmxnet3.ini
@@ -9,6 +9,7 @@ Link status event    = Y
 Queue start/stop     = Y
 MTU update           = Y
 Jumbo frame          = Y
+LRO                  = Y
 TSO                  = Y
 Promiscuous mode     = Y
 Allmulticast mode    = Y
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index cdbcb78..a41106d 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -540,6 +540,11 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
 	if (dev->data->dev_conf.rxmode.hw_ip_checksum)
 		devRead->misc.uptFeatures |= VMXNET3_F_RXCSUM;
 
+	if (dev->data->dev_conf.rxmode.enable_lro) {
+		devRead->misc.uptFeatures |= VMXNET3_F_LRO;
+		devRead->misc.maxNumRxSG = 0;
+	}
+
 	if (port_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
 		ret = vmxnet3_rss_configure(dev);
 		if (ret != VMXNET3_SUCCESS)
@@ -741,7 +746,8 @@ vmxnet3_dev_info_get(__rte_unused struct rte_eth_dev *dev,
 	dev_info->rx_offload_capa =
 		DEV_RX_OFFLOAD_VLAN_STRIP |
 		DEV_RX_OFFLOAD_UDP_CKSUM |
-		DEV_RX_OFFLOAD_TCP_CKSUM;
+		DEV_RX_OFFLOAD_TCP_CKSUM |
+		DEV_RX_OFFLOAD_TCP_LRO;
 
 	dev_info->tx_offload_capa =
 		DEV_TX_OFFLOAD_VLAN_INSERT |
-- 
1.9.1

  parent reply	other threads:[~2016-08-29 19:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-13  0:58 [dpdk-dev] [PATCH 0/4] various vmxnet3 fixes and enhancement Yong Wang
2016-08-13  0:58 ` [dpdk-dev] [PATCH 1/4] net/vmxnet3: improve error checks and return values Yong Wang
2016-08-13  0:58 ` [dpdk-dev] [PATCH 2/4] net/vmxnet3: coding style changes Yong Wang
2016-08-13  0:58 ` [dpdk-dev] [PATCH 3/4] net/vmxnet3: reallocate shared memzone on re-config Yong Wang
2016-08-13  0:58 ` [dpdk-dev] [PATCH 4/4] net/vmxnet3: enable lro Yong Wang
2016-08-22 11:21   ` Thomas Monjalon
2016-08-24  0:05   ` [dpdk-dev] [PATCH v2 0/6] various vmxnet3 fixes and enhancement Yong Wang
2016-08-24  0:05     ` [dpdk-dev] [PATCH v2 1/6] net/vmxnet3: improve error checks and return values Yong Wang
2016-08-29 19:18       ` [dpdk-dev] [PATCH v3 0/6] various vmxnet3 fixes and enhancement Yong Wang
2016-08-29 19:18         ` [dpdk-dev] [PATCH v3 1/6] net/vmxnet3: improve error checks and return values Yong Wang
2016-08-29 19:18         ` [dpdk-dev] [PATCH v3 2/6] net/vmxnet3: coding style changes Yong Wang
2016-08-29 19:18         ` [dpdk-dev] [PATCH v3 3/6] net/vmxnet3: reallocate shared memzone on re-config Yong Wang
2016-08-29 19:18         ` [dpdk-dev] [PATCH v3 4/6] net/vmxnet3: update feature doc Yong Wang
2016-08-29 19:18         ` [dpdk-dev] [PATCH v3 5/6] net/vmxnet3: update nic doc Yong Wang
2016-08-29 19:18         ` Yong Wang [this message]
2016-09-19 14:44         ` [dpdk-dev] [PATCH v3 0/6] various vmxnet3 fixes and enhancement Bruce Richardson
2016-08-24  0:05     ` [dpdk-dev] [PATCH v2 2/6] net/vmxnet3: coding style changes Yong Wang
2016-08-24  0:05     ` [dpdk-dev] [PATCH v2 3/6] net/vmxnet3: reallocate shared memzone on re-config Yong Wang
2016-08-24  0:05     ` [dpdk-dev] [PATCH v2 4/6] net/vmxnet3: update feature doc Yong Wang
2016-08-24  0:05     ` [dpdk-dev] [PATCH v2 5/6] net/vmxnet3: update nic doc Yong Wang
2016-08-24  0:05     ` [dpdk-dev] [PATCH v2 6/6] net/vmxnet3: enable lro Yong Wang
2016-08-24 19:17     ` [dpdk-dev] [PATCH v2 0/6] various vmxnet3 fixes and enhancement Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472498330-18591-7-git-send-email-yongwang@vmware.com \
    --to=yongwang@vmware.com \
    --cc=dev@dpdk.org \
    --cc=diproiettod@vmware.com \
    --cc=gyang@vmware.com \
    --cc=jsnell@iki.fi \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).