DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] testpmd: fix crash when mempool allocation fails
@ 2016-09-09  8:16 Olivier Matz
  2016-09-09  8:25 ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Olivier Matz @ 2016-09-09  8:16 UTC (permalink / raw)
  To: dev, pablo.de.lara.guarch; +Cc: stable

Avoid access to mempool pointer if it is NULL.

Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code")
Coverity issue: 127553

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 app/test-pmd/testpmd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 1428974..e0f8285 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -444,10 +444,13 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
 				mb_size, (unsigned) mb_mempool_cache,
 				sizeof(struct rte_pktmbuf_pool_private),
 				socket_id, 0);
+			if (rte_mp == NULL)
+				goto err;
 
 			if (rte_mempool_populate_anon(rte_mp) == 0) {
 				rte_mempool_free(rte_mp);
 				rte_mp = NULL;
+				goto err;
 			}
 			rte_pktmbuf_pool_init(rte_mp, NULL);
 			rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL);
@@ -458,6 +461,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
 		}
 	}
 
+ err:
 	if (rte_mp == NULL) {
 		rte_exit(EXIT_FAILURE,
 			"Creation of mbuf pool for socket %u failed: %s\n",
-- 
2.8.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-09-23 18:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-09  8:16 [dpdk-dev] [PATCH] testpmd: fix crash when mempool allocation fails Olivier Matz
2016-09-09  8:25 ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu
2016-09-09  8:43   ` Olivier Matz
2016-09-09  9:40 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2016-09-09  9:41   ` Olivier Matz
2016-09-09  9:42 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2016-09-21 23:02   ` De Lara Guarch, Pablo
2016-09-23 18:17     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).