From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Matthew Hall <mhall@mhcomputing.net> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size Date: Mon, 27 Oct 2014 22:41:50 +0100 Message-ID: <14734459.GQrgyakFfW@xps13> (raw) In-Reply-To: <20141027202108.GA13632@mhcomputing.net> 2014-10-27 13:21, Matthew Hall: > On Mon, Oct 27, 2014 at 03:13:39PM +0100, Thomas Monjalon wrote: > > You didn't answer to my previous comment on this. > > I think these definitions are useless. 64 is 64. > > Putting labels on the constants gives meaning to them as well as a numeric > value. Not doing so is an antipattern referred to as "magic numbers" > antipattern. Are you kidding Matthew? I'm referring to these constants: > +#define ETH_RSS_RETA_SIZE_64 64 > +#define ETH_RSS_RETA_SIZE_128 128 > +#define ETH_RSS_RETA_SIZE_512 512 It's not RETA_SIZE which would have a meaning but RETA_SIZE_64. We could also define RETA_SIZE_32 or RETA_SIZE_33... > A maintainence programmer or community member will have a difficult time > figuring out lost context when grepping through the code. > > Matthew.
next prev parent reply other threads:[~2014-10-27 21:33 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-25 8:40 [dpdk-dev] [PATCH v2 00/13] support of multiple sizes of redirection table Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 01/13] app/testpmd: code style fix Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 02/13] i40evf: " Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 03/13] ethdev: add more annotation Helin Zhang 2014-10-21 20:38 ` Thomas Monjalon 2014-10-21 22:20 ` Zhang, Helin 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-10-21 20:53 ` Thomas Monjalon 2014-10-28 0:33 ` Zhang, Helin 2014-10-28 10:10 ` Thomas Monjalon 2014-10-28 10:18 ` Richardson, Bruce 2014-10-28 13:20 ` Zhang, Helin 2014-10-28 14:22 ` Thomas Monjalon 2014-10-29 8:18 ` Zhang, Helin 2014-10-28 12:00 ` Zhang, Helin 2014-10-28 12:13 ` Thomas Monjalon 2014-10-28 12:36 ` Zhang, Helin 2014-10-29 8:24 ` Zhang, Helin 2014-10-29 10:00 ` Thomas Monjalon 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 05/13] igb: add new function for VF ops of 'dev_infos_get' Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 06/13] igb: rework of updating/querying reta Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 07/13] ixgbe: add new function for VF ops of 'dev_infos_get' Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 08/13] ixgbe: rework of updating/querying reta Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 09/13] i40e: support of setting hash lookup table size Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 10/13] i40e: support of getting redirection " Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 11/13] i40e: rework of updating/querying reta Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 12/13] i40evf: support of updating/querying redirection table Helin Zhang 2014-09-25 8:40 ` [dpdk-dev] [PATCH v2 13/13] app/testpmd: rework of commands for updating/querying reta Helin Zhang 2014-10-10 3:11 ` [dpdk-dev] [PATCH v2 00/13] support of multiple sizes of redirection table Liang, Cunming 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 0/8] " Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 1/8] app/testpmd: code style fix Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 2/8] i40evf: " Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-10-27 14:13 ` Thomas Monjalon 2014-10-27 20:21 ` Matthew Hall 2014-10-27 21:41 ` Thomas Monjalon [this message] 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 5/8] ixgbe: " Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-10-27 14:23 ` Thomas Monjalon 2014-10-28 0:37 ` Zhang, Helin 2014-10-28 10:04 ` Thomas Monjalon 2014-10-31 1:39 ` Zhang, Helin 2014-10-31 8:46 ` Thomas Monjalon 2014-10-22 11:53 ` [dpdk-dev] [PATCH v3 8/8] i40evf: support of updating/querying " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 0/8] support of multiple sizes of " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 1/8] app/testpmd: code style fix Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 2/8] i40evf: " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 5/8] ixgbe: " Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-11-05 20:52 ` Thomas Monjalon 2014-11-06 1:02 ` Zhang, Helin 2014-11-06 8:33 ` Thomas Monjalon 2014-11-06 8:52 ` Zhang, Helin 2014-10-31 9:03 ` [dpdk-dev] [PATCH v4 8/8] i40evf: support of updating/querying " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 0/8] support of multiple sizes of " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 1/8] app/testpmd: code style fix Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 2/8] i40evf: " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 5/8] ixgbe: " Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-11-06 14:25 ` [dpdk-dev] [PATCH v5 8/8] i40evf: support of updating/querying " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 0/8] support of multiple sizes of " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 1/8] app/testpmd: code style fix Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 2/8] i40evf: " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 3/8] i40e: support of setting hash lookup table size Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 5/8] ixgbe: " Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 7/8] ethdev: support of multiple sizes of redirection table Helin Zhang 2014-11-15 16:03 ` [dpdk-dev] [PATCH v6 8/8] i40evf: support of updating/querying " Helin Zhang 2014-11-24 22:20 ` Thomas Monjalon 2014-11-25 0:28 ` Zhang, Helin 2014-11-17 13:39 ` [dpdk-dev] [PATCH v6 0/8] support of multiple sizes of " Ananyev, Konstantin 2014-11-24 22:00 ` Thomas Monjalon 2014-11-19 9:28 ` Chen, Erlu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=14734459.GQrgyakFfW@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=mhall@mhcomputing.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git