From: Thomas Monjalon <thomas@monjalon.net>
To: Jun Qiu <jun.qiu@jaguarmicro.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
stable@dpdk.org, "Hu, Jiayu" <jiayu.hu@intel.com>
Subject: Re: [PATCH] gro: fix gro with ethernet tail padding bytes
Date: Sun, 09 Oct 2022 19:26:51 +0200 [thread overview]
Message-ID: <14738959.JCcGWNJJiE@thomas> (raw)
In-Reply-To: <f70c7290d48643bb84620a11e6cbaf61@intel.com>
15/08/2022 03:27, Hu, Jiayu:
> From: Jun Qiu <jun.qiu@jaguarmicro.com>
> >
> > I don't think the stack(software) cares if the length of a packet is less than 60,
> > especially when receiving it.
> > In the linux kernel, if the packet length does not match the IP total-length,
> > the packet is flushed to the stack instead of GRO. The previous GRO cache
> > packets are also flushed into the stack.
> >
> > If you trim padding in merge_two_tcp4_packets(), then both "pkt_head"
> > and "pkt_tail" need to decide whether to trim or not, which can be a bit tricky
> > to handle.
>
> OK. This patch is OK for me.
>
> Acked-by: Jiayu Hu <Jiayu.hu@intel.com>
Applied, thanks.
prev parent reply other threads:[~2022-10-09 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 8:00 Jun Qiu
2022-07-28 1:55 ` Hu, Jiayu
2022-07-28 11:02 ` Jun Qiu
2022-08-15 1:27 ` Hu, Jiayu
2022-10-09 17:26 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14738959.JCcGWNJJiE@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=jun.qiu@jaguarmicro.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).