From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 762C6A0542; Sun, 9 Oct 2022 19:26:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF8D8410D1; Sun, 9 Oct 2022 19:26:57 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 1498140042; Sun, 9 Oct 2022 19:26:56 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C99D932001C6; Sun, 9 Oct 2022 13:26:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 09 Oct 2022 13:26:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665336414; x= 1665422814; bh=e6YLMiAZri/MU6/DMiVzUy9i3h8IT/5FTsozpehtf5k=; b=S /Y87KovGC9jH25Mo6CisjdE/3hF0YcD95poRSCp8hhk2MF1jCVC5pi/bbaOKReUk pySbBUuEAxSOe3qshI9HJ9nzsTq2LYkpEvSJtzEfqziUK7qR61PVW3N4iZ4bmFmx qL41D50o+nqSgvjQOYaYjQ+Acc+1C2YyKj6ewQBIcXUn87WNVgCXRQBv+uPZ6mcG jagfe0g4oQV+U6TbCM8AAqqlSQ7OHjArJV1dp6/ABnBuAAUYe2OiR3q6VldnI5fQ +CpOv6qSWB5ZRMyXx440r55ML+FnNEL5WTQFHnxpp47Hae1mOoOcHqI71vI2BB8O 5fec6xVZ5m8GrlUBinD/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665336414; x= 1665422814; bh=e6YLMiAZri/MU6/DMiVzUy9i3h8IT/5FTsozpehtf5k=; b=p Pdgei7+wZDMqNcTzVrdzneY/JwPQ1bPAgN164ugxTpJpQgfEtuqQCk54sSmRJsTs GWefcUOwmeaxHQMI+RPr5d6Rm6qdVkUNyY8ekGQ2aIrYVEQ/K2YpYhQk5LSUzNbJ G5S4puL5g1MwWe8qFFhYnib5hf6vyPiBITvfG5J+qNrmi5b+9Xa9dHKSDHPLgBB1 C4inN2XicKIakU68mPpFWGFjtZovkTwk54/uRwJFAb2gbt2wxKukw/ec1JDRdG4z cVQ0JhHW5TQQcbsO57M7JmsrZUOuyF73BScn4sHntwrhvK/8X2SOq9YleAo6YRWI nAG2MWC7GexrWUkbDk22g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejuddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Oct 2022 13:26:52 -0400 (EDT) From: Thomas Monjalon To: Jun Qiu Cc: "dev@dpdk.org" , stable@dpdk.org, "Hu, Jiayu" Subject: Re: [PATCH] gro: fix gro with ethernet tail padding bytes Date: Sun, 09 Oct 2022 19:26:51 +0200 Message-ID: <14738959.JCcGWNJJiE@thomas> In-Reply-To: References: <20220727080036.27263-1-jun.qiu@jaguarmicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/08/2022 03:27, Hu, Jiayu: > From: Jun Qiu > > > > I don't think the stack(software) cares if the length of a packet is less than 60, > > especially when receiving it. > > In the linux kernel, if the packet length does not match the IP total-length, > > the packet is flushed to the stack instead of GRO. The previous GRO cache > > packets are also flushed into the stack. > > > > If you trim padding in merge_two_tcp4_packets(), then both "pkt_head" > > and "pkt_tail" need to decide whether to trim or not, which can be a bit tricky > > to handle. > > OK. This patch is OK for me. > > Acked-by: Jiayu Hu Applied, thanks.