From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH] mk: fix verbosity zero
Date: Fri, 23 Sep 2016 01:42:47 +0200 [thread overview]
Message-ID: <1474587767-20033-1-git-send-email-thomas.monjalon@6wind.com> (raw)
In-Reply-To: <6873211.QDWnoOkD9j@xps13>
Verbosity is considered enabled when $V is not empty.
So V=0 and V=1 are equivalent.
It is fixed by unsetting V when it is 0.
A side effect is to fix kernel module compilation verbosity
which is set to 0 when V is empty.
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
mk/rte.sdkroot.mk | 3 +++
mk/rte.vars.mk | 3 +++
2 files changed, 6 insertions(+)
diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
index 55a9d8a..04ad523 100644
--- a/mk/rte.sdkroot.mk
+++ b/mk/rte.sdkroot.mk
@@ -34,6 +34,9 @@ MAKEFLAGS += --no-print-directory
# define Q to '@' or not. $(Q) is used to prefix all shell commands to
# be executed silently.
Q=@
+ifeq '$V' '0'
+override V=
+endif
ifdef V
ifeq ("$(origin V)", "command line")
Q=
diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk
index 28982a5..c240a0e 100644
--- a/mk/rte.vars.mk
+++ b/mk/rte.vars.mk
@@ -46,6 +46,9 @@ endif
# define Q to '@' or not. $(Q) is used to prefix all shell commands to
# be executed silently.
Q=@
+ifeq '$V' '0'
+override V=
+endif
ifdef V
ifeq ("$(origin V)", "command line")
Q=
--
2.7.0
next prev parent reply other threads:[~2016-09-22 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 12:33 [dpdk-dev] [PATCH] mk: remove module compilation noise Ferruh Yigit
2016-09-22 23:35 ` Thomas Monjalon
2016-09-22 23:42 ` Thomas Monjalon [this message]
2016-09-23 9:06 ` [dpdk-dev] [PATCH] mk: fix verbosity zero Ferruh Yigit
2016-09-23 9:30 ` Thomas Monjalon
2016-09-23 9:33 ` Ferruh Yigit
2016-09-23 14:26 ` Thomas Monjalon
2016-09-23 9:04 ` [dpdk-dev] [PATCH] mk: remove module compilation noise Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474587767-20033-1-git-send-email-thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).