From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jincheng Miao <jmiao@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/4] kni: replace strict_strtoul with kstrtoul
Date: Wed, 10 Dec 2014 10:18:40 +0100 [thread overview]
Message-ID: <1474820.EkRfEgf9QI@xps13> (raw)
In-Reply-To: <957926828.25865702.1418201305408.JavaMail.zimbra@redhat.com>
2014-12-10 03:48, Jincheng Miao:
> > It seems you forgot to include the new compat.h.
> >
> > Did you do some tests with different Fedora/RHEL versions?
>
> Yes, missing compat.h in kni_vhost.c.
>
>
> And, I want to get your opinion about adding compat.h to kni and xen_dom0.
> The pros: easy to implement and minimal wrapper for older kernel.
Yes I think it's the good approach.
> The cons: there is so many compat.h, and the file kcompat.h also makes user confuse.
Why kcompat makes user confuse?
Do you think you could send a new version quickly to integrate it in the
next RC (probably today)?
Please test it with RHEL.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-12-10 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 3:32 [dpdk-dev] [PATCH 0/4] compatibility fallback and replacement of kernel function invoking Jincheng Miao
2014-12-10 3:33 ` [dpdk-dev] [PATCH 1/4] igb_uio: compatible with upstream longterm kernel and RHEL Jincheng Miao
2014-12-10 3:33 ` [dpdk-dev] [PATCH 2/4] igb_uio: replace strict_strtoul with kstrtoul Jincheng Miao
2014-12-10 3:33 ` [dpdk-dev] [PATCH 3/4] kni: " Jincheng Miao
2014-12-10 8:39 ` Thomas Monjalon
2014-12-10 8:48 ` Jincheng Miao
2014-12-10 9:18 ` Thomas Monjalon [this message]
2014-12-10 9:39 ` Jincheng Miao
2014-12-10 3:33 ` [dpdk-dev] [PATCH 4/4] xen_dom0: " Jincheng Miao
2014-12-10 8:39 ` Thomas Monjalon
2014-12-10 3:58 ` [dpdk-dev] [PATCH 0/4] compatibility fallback and replacement of kernel function invoking Zhang, Helin
2014-12-10 4:15 ` Jincheng Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474820.EkRfEgf9QI@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jmiao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).