From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 7FA087E79
 for <dev@dpdk.org>; Wed, 10 Dec 2014 10:19:35 +0100 (CET)
Received: by mail-wi0-f178.google.com with SMTP id em10so4399576wid.11
 for <dev@dpdk.org>; Wed, 10 Dec 2014 01:19:35 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=HRWjheE9NZIZTURhznfF3JJ+8H73I1kA2vKIZtRrNbQ=;
 b=FWw10y15yHvYEfcpSBteNrTQ9VRtsjeF3CMFFzHYwLNLZEyCamoo5rKoO42LUbJvaT
 IPTaUVhYX6L/zg1oZz1BHBHPO5t+cxRQNgsNUVVJnERCOR2a4d2V6x//S2s/0nCP2cwl
 MeqNUxMlq0+h4txFWeTBz0e2VHO+95qKXxqNSOGqcx0byBEQDfzx8Ml1Rxmd+dcMK6Fq
 Yp4lDbzgXPI4DhX5tSL6ITL2zo9zUzogGMfMWvzd4oR8JMbTi7TIIY9MkPQQOFA+7CvA
 sVvorhUnO5dUQpItr2avomxVKrz2dmixad5yPy1DMHAvvMQMHTiPzgf/ZT1Ykp5426HO
 vCdA==
X-Gm-Message-State: ALoCoQkAGC+Nbg7xgrqkMzf68p1KQa37J+DlbSj31KmnMvP31DUR2nnFJfxqWx1IDyFMs82X/I2z
X-Received: by 10.180.85.6 with SMTP id d6mr4624103wiz.82.1418203175286;
 Wed, 10 Dec 2014 01:19:35 -0800 (PST)
Received: from xps13.localnet ([78.188.139.117])
 by mx.google.com with ESMTPSA id h8sm5507273wiy.17.2014.12.10.01.19.32
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 10 Dec 2014 01:19:34 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jincheng Miao <jmiao@redhat.com>
Date: Wed, 10 Dec 2014 10:18:40 +0100
Message-ID: <1474820.EkRfEgf9QI@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <957926828.25865702.1418201305408.JavaMail.zimbra@redhat.com>
References: <1418182383-5744-1-git-send-email-jmiao@redhat.com>
 <1663200.Cog0FQ0fDE@xps13>
 <957926828.25865702.1418201305408.JavaMail.zimbra@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/4] kni: replace strict_strtoul with kstrtoul
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Dec 2014 09:19:35 -0000

2014-12-10 03:48, Jincheng Miao:
> > It seems you forgot to include the new compat.h.
> > 
> > Did you do some tests with different Fedora/RHEL versions?
> 
> Yes, missing compat.h in kni_vhost.c.
> 
> 
> And, I want to get your opinion about adding compat.h to kni and xen_dom0.
> The pros: easy to implement and minimal wrapper for older kernel.

Yes I think it's the good approach.

> The cons: there is so many compat.h, and the file kcompat.h also makes user confuse.

Why kcompat makes user confuse?

Do you think you could send a new version quickly to integrate it in the
next RC (probably today)?

Please test it with RHEL.

Thanks
-- 
Thomas