From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id AF0EC7E80 for ; Tue, 28 Oct 2014 16:24:49 +0100 (CET) Received: by mail-wi0-f174.google.com with SMTP id q5so9685137wiv.13 for ; Tue, 28 Oct 2014 08:33:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9veQYlSl23q7bKZ4xBFpoigQKVkM7oXyUCFowA1Rsu0=; b=ald+KkV6HfEL0dpl5gH0XB7ahVwR846/00ttmJAZTj77mleb27QudEuXLbokBtJgGn 1QQvI4N1wGb1x/jypSDOFLhTVozGiixxIXiFnudLbrTezDHtTM/TMvVeI7wGhvbGtF3T QtT2OzLbAAoWK+eXaHR60KCwxdq2udkpR0ZP6vdrXjSjnu8kZrSFovus20PKF05hfXN7 vgYlIvb+4Vu4XluLYOHtd760wwg7xaNHZuiH4A02da2rWogM4Ls0Yv0N75O/zGZW1CFx fYPOQ8IWTmhmxfRKlr6Ow0SaWb7jQCz1kfaVWTf8Ov60hsrQrt9Tf0pKPid51/5BygaH 9ppA== X-Gm-Message-State: ALoCoQn/8zK2PD2P49k6f/hzgXPbT4a89mKlRKQfFzOu46GkzrOb0Qxcu5vsPAA/6S4EG2mkvwpn X-Received: by 10.180.39.237 with SMTP id s13mr5614630wik.52.1414510416735; Tue, 28 Oct 2014 08:33:36 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fa16sm15788335wid.5.2014.10.28.08.33.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Oct 2014 08:33:36 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Date: Tue, 28 Oct 2014 16:33:18 +0100 Message-ID: <1475630.rsklqHVhi2@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20141028145123.GA24266@sivswdev02.ir.intel.com> References: <1414078550-692-1-git-send-email-sergio.gonzalez.monroy@intel.com> <20141028145123.GA24266@sivswdev02.ir.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: link combined lib using CC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 15:24:49 -0000 2014-10-28 14:51, Sergio Gonzalez Monroy: > On Tue, Oct 28, 2014 at 11:45:28AM +0000, De Lara Guarch, Pablo wrote: > > > Building combined shared libs fails if we set EXTRA_CFLAGS=-O0. > > > > > > /usr/bin/ld: test: hidden symbol `mknod' in > > > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > > > /usr/bin/ld: final link failed: Bad value > > > collect2: error: ld returned 1 exit status > > > > > > Fix: link combined shared lib using CC if LINK_USING_CC is enabled. > > > > > > Signed-off-by: Sergio Gonzalez Monroy > > > > Plus, should we include compilation errors in commits? > > They are quite useful to identify the problem that > > the patch is solving, but not sure if this should be shown in the git log. > > > I was wondering about it myself. I think it is useful info but maybe t is more > appropiate to have it as a comment or cover letter just on the mailing list. > I don't have a strong preference for including it, maybe someone else has an > opinion about this? We are not limited in characters in the commit log. So every useful information (like error output) is more than welcome. The only thing which needs to be shorter than a twitter post, is the title. Because short and clear titles help to scroll commits. That said, don't put things which have no interest at all. Here I'd put only this: ld: test: hidden symbol `mknod' in /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO -- Thomas