From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 7A5E1593A for ; Mon, 5 Jan 2015 09:55:57 +0100 (CET) Received: by mail-we0-f173.google.com with SMTP id q58so7459020wes.4 for ; Mon, 05 Jan 2015 00:55:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=lop89dR10HguHDh5ytXJzZMubiP8VfnF/aGBIRTfMZI=; b=VolD96wcIPhoCGny7DnBRjVRwB+SneBGIg4QnGAtVzHGa2qyOtiN7w0YJRNy90ROxx 7lelES9UhzBJLPx0pxeNbEzrmkztbL6cE8COCLzRBLXVAYzmNJz7EEWnnq8+JJTgkBXA ba4cA6h9ev4PFCAsI/PiJfDixTlt3La0CK5bLzdtGXtRC/rYG3wjdhYB6qjeX4uRVOXj OnqX4bLqqQvWbO2FsDyhw9XB3EKmgj9rxafmvKVXo+b/KV6w5XxuRp++jx/I2gwK/99w XB4HBLPvVRfzA6oqK5l2QVumf8qgUmFEWw1n8l08Rps32hAi2nRbapC2gr4y4adR0Nmd uG2g== X-Gm-Message-State: ALoCoQku1Mdou1QWH9ql//XWQGX8R49dmLoY2pEX/w5Z7gsn3QXG/au1dNDM4knzTN6Y5wffC/nc X-Received: by 10.194.108.202 with SMTP id hm10mr181322278wjb.72.1420448157322; Mon, 05 Jan 2015 00:55:57 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id cp4sm74526644wjb.16.2015.01.05.00.55.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2015 00:55:56 -0800 (PST) From: Thomas Monjalon To: Ravi Kerur Date: Mon, 05 Jan 2015 09:55:35 +0100 Message-ID: <1475634.GuJD5gSMru@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 08:55:57 -0000 2015-01-04 15:28, Ravi Kerur: > We have a Gigabyte H97N motherboard which has I217 Intel chipset which uses > e100e drivers. I looked into lib/librte_pmd_e1000 directory and I do see > that e1000e code is integrated but missing some support for read/write from > flash_address and other minor things. I have made changes shown below and > have done some testing with testpmd utility and now have following questions > > 1. What amount of testing is required to qualify patch as successfully > tested on new chipsets There is no good answer to this question. Generally, you must be sure that you don't break anything. So you must test the code paths you have changed. > 2. FreeBSD testing, currently we have Ubuntu 14.04 installed on existing > H97N motherboard and testing is done solely on Linux. We plan to get > another motherboard which will have I218 chipset and still deciding whether > to go with FreeBSD or Ubuntu. So the question I have is what amount of > testing should be done on FreeBSD? I don't think setup.sh/dpdk_nic_bind.py > works on FreeBSD yet hence the question on testing. FreeBSD testing is required when patching common EAL, scripts or makefiles. > > lib/librte_pmd_e1000/e1000/e1000_api.c | 21 +++++++++++++++++++++ > > lib/librte_pmd_e1000/e1000/e1000_api.h | 1 + > > lib/librte_pmd_e1000/e1000/e1000_osdep.h | 24 +++++++++++++++++++----- These files are part of the base driver. The rule is to not patch them and try to do the changes in PMD only. There can be exceptions if an Intel maintainer acknowledges it. -- Thomas