From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A676A09FF; Wed, 30 Dec 2020 08:31:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34415C8DC; Wed, 30 Dec 2020 08:31:53 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CABC62D41; Wed, 30 Dec 2020 08:31:50 +0100 (CET) IronPort-SDR: U1TRU+W/JebrltmQrx23EYEpj0dcHmu6E+8m0WBe3As29jevahfYcOkm3CfTNSZ6oWT5lIml6E vsQ3MzhSyMcQ== X-IronPort-AV: E=McAfee;i="6000,8403,9849"; a="155778473" X-IronPort-AV: E=Sophos;i="5.78,460,1599548400"; d="scan'208";a="155778473" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2020 23:31:48 -0800 IronPort-SDR: ADaVxBVEY3bMKaAJRfdHhyUfqgxRpeF3CN4qFZ2ns+/R0CG5XSy/pvHCzstkHu97/w6MmIDHS4 R6yZ/G7JiDyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,460,1599548400"; d="scan'208";a="494865802" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 29 Dec 2020 23:31:48 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 29 Dec 2020 23:31:46 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 30 Dec 2020 15:31:44 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Wed, 30 Dec 2020 15:31:44 +0800 From: "Xie, WeiX" To: "Yu, DapengX" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Yu, DapengX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment Thread-Index: AQHW3nihF7otXA6j5kSOZSbz8idYz6oPPpuA Date: Wed, 30 Dec 2020 07:31:44 +0000 Message-ID: <1476436bbfde461f87eaeb8603dd87f2@intel.com> References: <20201230065347.90115-1-dapengx.yu@intel.com> In-Reply-To: <20201230065347.90115-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Xie,WeiX < weix.xie@intel.com> Regards, Xie Wei > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of > dapengx.yu@intel.com > Sent: Wednesday, December 30, 2020 2:54 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment >=20 > From: YU DAPENG >=20 > When the interrupt handle instance allows none packet I/O interrupts, the > max value of vector_id is set to be less than the number of msix interrup= ts, > but not equal to it. Which may cause same vector_id is sent to PF with > opcode VIRTCHNL_OP_CONFIG_IRQ_MAP to setup the cause of interrupt > mapping in iavf_config_irq_map(), these are invalid parameters, cause err= or: > VIRTCHNL_STATUS_ERR_PARAM(-5). So add code to set the max value of > vector_id to be equal to the number of msix interrupts. >=20 > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") > Cc: stable@dpdk.org >=20 > Signed-off-by: YU DAPENG > --- > drivers/net/iavf/iavf_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 7e3c26a94..54ea3a36c 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -578,7 +578,7 @@ static int iavf_config_rx_queues_irqs(struct > rte_eth_dev *dev, > qv_map[i].queue_id =3D i; > qv_map[i].vector_id =3D vec; > intr_handle->intr_vec[i] =3D vec++; > - if (vec >=3D vf->nb_msix) > + if (vec > vf->nb_msix) > vec =3D IAVF_RX_VEC_START; > } > vf->qv_map =3D qv_map; > -- > 2.27.0