From: "E. Scott Daniels" <daniels@research.att.com>
To: helin.zhang@intel.com, bernard.iremonger@intel.com
Cc: dev@dpdk.org, az5157@att.com,
"E. Scott Daniels" <daniels@research.att.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list
Date: Wed, 19 Oct 2016 18:23:07 -0400 [thread overview]
Message-ID: <1476915787-28205-2-git-send-email-daniels@research.att.com> (raw)
In-Reply-To: <1476915787-28205-1-git-send-email-daniels@research.att.com>
This change prevents the attempt to add a structure which is
already on the callback list. If a struct with matching
parameters is found on the list, then no action is taken. If
a struct with matching parameters is found on the list, then
no action is taken.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
---
lib/librte_ether/rte_ethdev.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 0d9d9c1..fde8112 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -2449,14 +2449,15 @@ rte_eth_dev_callback_register(uint8_t port_id,
}
/* create a new callback. */
- if (user_cb == NULL)
+ if (user_cb == NULL) {
user_cb = rte_zmalloc("INTR_USER_CALLBACK",
sizeof(struct rte_eth_dev_callback), 0);
- if (user_cb != NULL) {
- user_cb->cb_fn = cb_fn;
- user_cb->cb_arg = cb_arg;
- user_cb->event = event;
- TAILQ_INSERT_TAIL(&(dev->link_intr_cbs), user_cb, next);
+ if (user_cb != NULL) {
+ user_cb->cb_fn = cb_fn;
+ user_cb->cb_arg = cb_arg;
+ user_cb->event = event;
+ TAILQ_INSERT_TAIL(&(dev->link_intr_cbs), user_cb, next);
+ }
}
rte_spinlock_unlock(&rte_eth_dev_cb_lock);
--
1.9.1
next prev parent reply other threads:[~2016-10-19 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 22:23 E. Scott Daniels
2016-10-19 22:23 ` E. Scott Daniels [this message]
2016-10-20 1:39 ` Lu, Wenzhuo
2016-10-20 2:11 ` Scott Daniels
2016-10-20 2:19 ` Lu, Wenzhuo
2016-10-20 2:31 ` Scott Daniels
2016-10-20 13:35 ` Scott Daniels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476915787-28205-2-git-send-email-daniels@research.att.com \
--to=daniels@research.att.com \
--cc=az5157@att.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).