From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id EEF872952 for ; Wed, 12 Oct 2016 18:31:12 +0200 (CEST) Received: by mail-lf0-f46.google.com with SMTP id b75so83370173lfg.3 for ; Wed, 12 Oct 2016 09:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=AH2p3I7FVxrNK6Qd1x7Wz0Ax2dpnTtHgLCrG6/METnQ=; b=EUbtNPO0UHLP2nlUpewz5c5oc3lK0eFC6TZDx7d61qjvgWqg3QjXUNZhzqrE2IbwX4 grNi75gotvk879JTMlOLWkDAG3KtYmCqPIj9sA0ES9g+Revb/uikrmEzfVNAly4NdbSR G5GvdrubjE5R/NGmx68NQxN+ECw5N9HPFB++yN3fRLscHq+N+8+YaPfBPo3aD04Qv2/H yHJFzNli6SRk3TLHHXh0c/EkQA9NKnnUF4Ne09Bmrq54V823qAnc9ZDRwgf8IGWD+Hot OVwzHdERQ1+LDNxRm1ELB1dWVXoN++/Af0E7QBouvT66wRljbGsNshBijxbLD1FG2Y5h OZ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=AH2p3I7FVxrNK6Qd1x7Wz0Ax2dpnTtHgLCrG6/METnQ=; b=UwWIxeZrbCpRbXvCJ9bFX7iQiaBHhDpJdKIPWKAIaqkMuVO3KfimQpaVI6smnP651q x9t6tsijZBr7Bdb+IzGA8MC5KI2OZBi3vS66vtH75EesEO08v/dRKZDkH7eb9DLJFZ4g wd6SP0cOIeY8xBnp57RITq1USJRDbBzr2906Hw3XaTd2pQeYq/HmV10mynkUUroIxQmD GC/Pcm7CgH+xqbMPwGB3Pg15TEyKEfY0QORuiRaXq+SjLQmSrDaU9lRFDg0JhQyBU2Q7 ldzkPF0mC2eNwEkhrzlTdokPvk6ediOUN9s8WgSWxwFOsUtYRm27wnEG+QvxTXzT1dIA n9uA== X-Gm-Message-State: AA6/9RkhG+TWdPd43cpfu+9bvR1Xq4kAhMD8/5AnmQCXeFr5HgOAfOGAT/iBeXLZu/Bgj3LB X-Received: by 10.25.228.90 with SMTP id b87mr2576636lfh.61.1476289872530; Wed, 12 Oct 2016 09:31:12 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id y81sm2435831lff.29.2016.10.12.09.31.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Oct 2016 09:31:11 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "De Lara Guarch, Pablo" Date: Wed, 12 Oct 2016 18:31:10 +0200 Message-ID: <1477008.RUhcNVuyge@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A092162@IRSMSX108.ger.corp.intel.com> References: <1475858784-5303-1-git-send-email-bernard.iremonger@intel.com> <4355552.XQIr0B1y70@xps13> <8CEF83825BEC744B83065625E567D7C21A092162@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 16:31:13 -0000 2016-10-12 16:21, Iremonger, Bernard: > Hi Thomas, > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests > > > > > > for new API's > > > > > > > > > > > > 2016-10-12 16:03, Bernard Iremonger: > > > > > > > --- a/app/test-pmd/Makefile > > > > > > > +++ b/app/test-pmd/Makefile > > > > > > > @@ -58,6 +58,17 @@ SRCS-y += csumonly.c SRCS-y += icmpecho.c > > > > > > > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > > > > > > > > > > > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) > > > > > > > +LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > > > endif > > > > > > > + > > > > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > > > > > > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > > > > > > +LDLIBS += -lrte_pmd_ixgbe > > > > > > > +endif > > > > > > > +endif > > > > > > > > > > > > Sorry if I miss something, but I thought it was enough to do: > > > > > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > > > > > > > > > No unfortunately not, the above line does not work for all scenarios . > > > > > > > > > > There are 4 scenarios as follows: > > > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=y with > > > > CONFIG_RTE_BUILD_SHARED_LIB=n > > > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=y with > > > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=n with > > > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=n with > > > > CONFIG_RTE_BUILD_SHARED_LIB=n > > > > > > > > > > I have been doing quite a bit of building today to get it to work > > > > > in all 4 > > > > scenarios. > > > > > > > > I have a doubt about the tests because LDLIBS-y does not exist. > > > > There is _LDLIBS-y and LDLIBS. > > > > But in the static case, you wrote: > > > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > endif > > > > Please could you check? > > > > > > LDLIBS-y exists in some of the scenarios but not all. > > > > I think I'm something obvious. > > Please could you point the line where LDLIBS-y is used? > > Line 62 of latest Makefile; > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe No, I mean where do you find LDLIBS- (without underscore) before your patch? git grep '\