DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bernard Iremonger <bernard.iremonger@intel.com>
To: dev@dpdk.org, rahul.r.shah@intel.com, jingjing.wu@intel.com,
	wenzhuo.lu@intel.com
Subject: [dpdk-dev] [PATCH v7] app/testpmd: fix DCB configuration
Date: Fri, 28 Oct 2016 15:40:15 +0100	[thread overview]
Message-ID: <1477665615-3723-1-git-send-email-bernard.iremonger@intel.com> (raw)
In-Reply-To: <1477414269-27156-3-git-send-email-bernard.iremonger@intel.com>

Data Centre Bridge (DCB) configuration fails when SRIOV is
enabled if nb_rxq and nb_txq are not set to 1.

When dcb_mode is DCB_VT_ENABLED and max_vfs is greater than
zero, set nb_rxq and nb_txq to 1.

The failure occurs during configuration of the ixgbe PMD when
it is started, in the ixgbe_check_mq_mode function, if nb_rxq
and nb_txq are not set to 1.

Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>

Changes in v7:
restore nb_rxq and nb_txq setting when max_vfs is 0.
---
 app/test-pmd/testpmd.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 6185be6..96f5011 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2002,8 +2002,13 @@ init_port_dcb_config(portid_t pid,
 	 * and has the same number of rxq and txq in dcb mode
 	 */
 	if (dcb_mode == DCB_VT_ENABLED) {
-		nb_rxq = rte_port->dev_info.max_rx_queues;
-		nb_txq = rte_port->dev_info.max_tx_queues;
+		if (rte_port->dev_info.max_vfs > 0) {
+			nb_rxq = 1;
+			nb_txq = 1;
+		} else {
+			nb_rxq = rte_port->dev_info.max_rx_queues;
+			nb_txq = rte_port->dev_info.max_tx_queues;
+		}
 	} else {
 		/*if vt is disabled, use all pf queues */
 		if (rte_port->dev_info.vmdq_pool_base == 0) {
-- 
2.4.3

  parent reply	other threads:[~2016-10-28 14:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26  9:08 [dpdk-dev] [PATCH] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-09-21 11:07 ` Remy Horton
2016-10-14 13:29 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2016-10-17  6:12   ` Lu, Wenzhuo
2016-10-17 16:27     ` Iremonger, Bernard
2016-10-18  1:07       ` Lu, Wenzhuo
2016-10-18  8:58         ` Iremonger, Bernard
2016-10-19  0:39           ` Lu, Wenzhuo
2016-10-19 10:16             ` Iremonger, Bernard
2016-10-17 16:07   ` [dpdk-dev] [PATCH v3 0/2] net/ixgbe: " Bernard Iremonger
2016-10-17 17:01     ` [dpdk-dev] [PATCH v4 " Bernard Iremonger
2016-10-19 10:21       ` [dpdk-dev] [PATCH v5 " Bernard Iremonger
2016-10-25  0:31         ` Lu, Wenzhuo
2016-10-25 16:51         ` [dpdk-dev] [PATCH v6 " Bernard Iremonger
2016-10-25 16:51         ` [dpdk-dev] [PATCH v6 1/2] net/ixgbe: support multiqueue mode " Bernard Iremonger
2016-10-26 14:38           ` Wu, Jingjing
2016-10-26 15:29             ` Iremonger, Bernard
2016-10-26 16:09               ` Iremonger, Bernard
2016-10-26 16:33                 ` Wu, Jingjing
2016-10-25 16:51         ` [dpdk-dev] [PATCH v6 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger
2016-10-26 14:30           ` Wu, Jingjing
2016-10-26 15:28           ` [dpdk-dev] [PATCH v7] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-26 15:41             ` Bruce Richardson
2016-10-28 14:40           ` Bernard Iremonger [this message]
2016-11-01 10:36             ` [dpdk-dev] [PATCH v8] app/testpmd: fix DCB configuration Bernard Iremonger
2016-11-03 17:35               ` [dpdk-dev] [PATCH v9] " Bernard Iremonger
2016-11-04  5:40                 ` Wu, Jingjing
2016-11-07 15:56                   ` Thomas Monjalon
2016-10-19 10:21       ` [dpdk-dev] [PATCH v5 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-20  1:24         ` Lu, Wenzhuo
2016-10-19 10:21       ` [dpdk-dev] [PATCH v5 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger
2016-10-17 17:01     ` [dpdk-dev] [PATCH v4 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-17 17:01     ` [dpdk-dev] [PATCH v4 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger
2016-10-17 16:07   ` [dpdk-dev] [PATCH v3 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Bernard Iremonger
2016-10-17 16:07   ` [dpdk-dev] [PATCH v3 2/2] app/test_pmd: fix DCB configuration Bernard Iremonger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477665615-3723-1-git-send-email-bernard.iremonger@intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=rahul.r.shah@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).