DPDK patches and discussions
 help / color / mirror / Atom feed
From: Elad Persiko <eladpe@mellanox.com>
To: dev@dpdk.org
Cc: Elad Persiko <eladpe@mellanox.com>
Subject: [dpdk-dev] [PATCH] net/mlx5: fix wrong use of vector instruction
Date: Tue,  1 Nov 2016 08:13:27 +0000	[thread overview]
Message-ID: <1477988007-26141-1-git-send-email-eladpe@mellanox.com> (raw)

Constraint alignment was not respected in Tx.

Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path")

Signed-off-by: Elad Persiko <eladpe@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 21164ba..ba8e202 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -309,7 +309,7 @@ mlx5_tx_dbrec(struct txq *txq)
 	*txq->qp_db = htonl(txq->wqe_ci);
 	/* Ensure ordering between DB record and BF copy. */
 	rte_wmb();
-	rte_mov16(dst, (uint8_t *)data);
+	memcpy(dst, (uint8_t *)data, 16);
 	txq->bf_offset ^= (1 << txq->bf_buf_size);
 }
 
@@ -449,7 +449,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
 		wqe->eseg.mss = 0;
 		wqe->eseg.rsvd2 = 0;
 		/* Start by copying the Ethernet Header. */
-		rte_mov16((uint8_t *)raw, (uint8_t *)addr);
+		memcpy((uint8_t *)raw, ((uint8_t *)addr), 16);
 		length -= MLX5_WQE_DWORD_SIZE;
 		addr += MLX5_WQE_DWORD_SIZE;
 		/* Replace the Ethernet type by the VLAN if necessary. */
-- 
1.8.3.1

             reply	other threads:[~2016-11-01  8:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01  8:13 Elad Persiko [this message]
2016-11-01 14:24 ` Ferruh Yigit
2016-11-02 15:56 ` Adrien Mazarguil
2016-11-07 17:16   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477988007-26141-1-git-send-email-eladpe@mellanox.com \
    --to=eladpe@mellanox.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).