From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 3AAAF8E81 for ; Tue, 24 Nov 2015 21:30:23 +0100 (CET) Received: by wmvv187 with SMTP id v187so227663945wmv.1 for ; Tue, 24 Nov 2015 12:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=US0WiznM+/KAOMckg1IHhV3fhEVKe0GlXRXIBvesXIw=; b=wDhcFYZwf+pmU9MDEobc07tIbBxdBn2ej4E2ph6Kc6408TiOG3Pgmv/pm8jls0Q0Bf tDcsvoewIKu+tBzfvfESN6wYKq9R6QDrYFpgpq6+fa1v/k7Mq/YgGp1g53nhjvfI4m47 DqSd+GQBFngIhfyly4o6x2OLE/A+MSlOL4k3wIfBgbIXdlmbVBNgm4B96Q/bbLcTRCPo cYn3ApsXGBaf5VTOY3LTP6Lr3RXJtScS/pXuR+jrZy+dSFY8KzgDvzL0vkSFi/TnuLOL r9C+lozYgRoYJPRT/2TSge5hYJXeA9ZCT8/WOM3n2mcfoCkM6ekHTMFnT1MpYkBKhRUj fCPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=US0WiznM+/KAOMckg1IHhV3fhEVKe0GlXRXIBvesXIw=; b=SpaUPMYYu3w/Ajuc1c46UqkIR17ZzmEe3AeNDsJ0aWtOKbpYTZBdA79lCofGTSnErr 2jgqhHnCf3DA/xTcgzyoynfjfXFhGg7yh8WT6faCIGy0oHJJJfJEBjuS+S3v4zRQchZX RVwwS+3AhmwsDVxHAw294q0cHYbZIsQ0UbYPfe62Hs5R88bNYVh8Q3JTzwxETij0+KwY zDPJnrdx9CbasyURWhDaKfpzc/hh2veXnQAEq5MV7+/MBcpkazl37lmnWp5WBtiMz/lB TtfY4IkcNsKoWpN+8P1g5OilG1kOBkR8rAC+8cj1675/gRP/xBo9cOqdbWymyhSbFsYk 0olQ== X-Gm-Message-State: ALoCoQlg7skX2161pxoSrJSyOren+1oECgo8IXwx5LkHEE58NJiLUUI3ZFA6Nvt2GkuzOY1JXdG1 X-Received: by 10.28.224.86 with SMTP id x83mr394030wmg.36.1448397023011; Tue, 24 Nov 2015 12:30:23 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id a76sm244206wma.19.2015.11.24.12.30.21 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Nov 2015 12:30:22 -0800 (PST) From: Thomas Monjalon To: Victor Kaplansky Date: Tue, 24 Nov 2015 21:29:04 +0100 Message-ID: <14789443.hoUPLFMsZ2@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151124094106-mutt-send-email-victork@redhat.com> References: <1448026465-27460-1-git-send-email-victork@redhat.com> <1448349935-1935-1-git-send-email-yuanhan.liu@linux.intel.com> <20151124094106-mutt-send-email-victork@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] vhost-user: fix enabling of queue pair X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 20:30:23 -0000 2015-11-24 09:43, Victor Kaplansky: > Yuanhan, looks fine. Thanks for handling this. > -- Victor > > On Tue, Nov 24, 2015 at 03:25:35PM +0800, Yuanhan Liu wrote: > > From: Victor Kaplansky > > > > The VHOST_USER_SET_VRING_ENABLE request was sent for each queue-pair. > > However, it's changed to be sent per queue in the queue-pair by QEMU > > commit dc3db6ad ("vhost-user: start/stop all rings"). The change > > is reasonable, as we send all other request per queue, instead of > > queue-pair. > > > > Hence we should do proper changes to adapt to the QEMU change here. > > Otherwise, a segfault will be triggered when last TX queue was enabled. > > > > [ commit log reword -- Yuanhan Liu ] > > > > Signed-off-by: Victor Kaplansky > > Acked-by: Yuanhan Liu > > --- > > > > v2: invoke vring_state_changed() callback per-vring as well > > > > This fixes a fatal issue, without that MQ will not work properly. > > Seems that Victor is busy at something else (or out of office so > > far), hence I sent v2 on behalf of him. Applied, thanks