From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0069.outbound.protection.outlook.com [104.47.38.69]) by dpdk.org (Postfix) with ESMTP id 4CD685582 for ; Fri, 18 Nov 2016 13:52:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UFdZVtyEy++WfLAJO1Oyd2U24xVTVnC3EzwmcEq2UHg=; b=Wg7sQ5jJFwdvPq58N2lGpn/5P5s9uNKRhr2HGPR+v1JBYb2O0MiYKZ/CuvSamLSFClHgMHV3J44NdA511Wm378VfbOCC9b9gtdatSQC6mHmIBMDPz1obbQnAMTs3rqGoqnxkt+EZsSUoIxQPKh1B+aQQumLwJs5HGyMaNwZupkw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Satha.Rao@cavium.com; Received: from tns2.caveonetworks.com (50.233.148.156) by MWHPR07MB2846.namprd07.prod.outlook.com (10.169.230.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.8; Fri, 18 Nov 2016 12:52:31 +0000 From: Satha Rao To: CC: , , , , Satha Rao Date: Fri, 18 Nov 2016 04:52:13 -0800 Message-ID: <1479473533-9393-1-git-send-email-skoteshwar@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: BN6PR1601CA0016.namprd16.prod.outlook.com (10.172.104.154) To MWHPR07MB2846.namprd07.prod.outlook.com (10.169.230.148) X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2846; 2:b74k8NaK5ZGV+kYOBYHUJLUqRb4OGXvRRGmiaZlfVJyeLInqCGCi2eRk6tr1WvLH6NdUK1FIXWfYpkzl6glbVtmOVPzwkqPb+U5bokzsrPzdxR7AWlvhZ593MUlFSiQy9St8KkdC6LZ4KNOc0e58UglAb6A6E97gQo+ZuhL5w1c=; 3:rJOpwIacdJnp7lWDQNtso1RnezU4QGWpaQjRwjFeTOb7bSGTbl1DDBt89aL7+z1ae1tMG1NXoV5cQNwU2/xNZFbi0zzIwMYEaSgKW/u1ci8Wu/Ndb09bXmwywI6fhmERetrjN7MJJyPvnMnOcmEhpRA0d2fT//0oSEUK5gfcstc= X-MS-Office365-Filtering-Correlation-Id: c0a41f06-3e61-47c8-0288-08d40fb1c34e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR07MB2846; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2846; 25:96xT8u5qHUKIdWzPV/SpuLb0e7qv5/4LHrN7yVZKjuYhs2tCdn5Yx2OIlonxBKatzZyufNuDHEs4Grtlg5KQwcqjgK1RkVbCAztpzF2PXdLLp99eis2L1opvJccmnUMJgbm17hKmj1vsHSPwkB1PQKh7+uM7RshIge6tSdFBZ3CZ8EIFjDVUsxDshbhUIB/QxLxB7z1Wq3zXBytnLcm+3Vrjzf8LRf3axL9unWXqCTv5GNSiWWZnm8VjjnS/n/08PJywLN2Wv+93LpKJxRwGPQRxx1SyaOf8feY+lmSGZC7lbOVXZjFkts72tEoiVQTQ71djfgPzuey7cy4rzeltAmgLdHTcvlDaPL780pUp/7/ELtgdmhiHy1Uir+A0ashgI0LifHrw5hpuD7nrYiubWL6Veom0kaFdDn1MVYoEFV1Gg9y7NncUXooE9VHhEj3cHDB7UrL2GHph1ohjHoYmc+cxRY0MmtjPo3GndxHTejP7NYJvxr4YmnRUQTSv/xEp8kF3MGuUwkyDCfjpGlnAWY4CKbT8HY1Pv+HM6VtiICa+W+40xWwBJfW9wBHjR1GeOFznAyM4D+D6kTtnJNm3uKO7vDg77yVP1nbz3IvHq64KRo5JR7+tNQt+5Zq0EbLlndOHHRRVF/iST5tPsIOQlxgGO9Ombbs8zpB/u/rOyOpQvy62pYrbc4keyzIyjnbjcXOdwD6WrG5vWe1+jFNCrMJYFRJd8vU+8QkR/NWVgb8xy/+QnT9F/HJ0hRnsOWgQlb3FEmvio97YcVQlhFH3Lg== X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2846; 31:fuM63BeJAXF8I7FMB6gkVJTGBETLI4P5kSd/jvQ2xIVja/7lNuV9YVdRwkb2w8S7XtXfHIAjr7NrFUu3Jqa7hWAcHZw/ygwSZOnnU1T6NMExWCHyQAiz67e8Pe8WgGbq4h3/Ra3s2y37iGe46PUP8GslcGT9+fJxaexLrgsRlQCsszAvHuy+qZOaATSDiH1ss4oCf1cT32Zqfd0Wh7jwRzcAhUtxQYbCBTacnHE6MRkkagDjNMQPvrLatpaN97ySlDMb6vx9G14tmFUclXSh61CZHd2syt6NJAWa7jwUOhk=; 20:bJnWUahsK3p/PW8Y0SsZ3si9B8KLw3RZ2nRejQqau3IschQnR+UgRWUgGGM2+QHLYHjidruD9NDRkEcz9e1qWgypvEsRz1tPBKfU1yDPZ0QTC4D3hW+GfCEJk2Cz6wBDYTw6ZMociuvO8Ld+KWF+q+YGcHsmtdn7KkNv5BD2TB+HDBwxJ78WjJHUynU/76EEVjhcEuAB5sSS2vjsPNYwB5COPEWl1Zw5rXR13etpMrt9A9U/UNv1LMbSTYI5Cln3VlmxVvY5GnwxwrecTPMI/ow4uKRwLhW1f550d/wriFkAr9+5YivCpmqkvi6PRDKFx/36P9QEnVoH7+yePgp+yjLUKR3ccTDjLRA/ZKjzB0rCgge8YICifCkiVZUVJuZ/VuMsyWdUTrwzvncF0GWTwIfqWZV/neLvU2M4gik+gdFBCk7ue3eIyDi3CkTr/tsSn/RfsuOE403GkENid/AePP/ACSCTI5XZ7wo2Y0+T9q5Il+lD4lAjFBf8oE6KOhsU4j23y9ZM1BQqlcNeDHbXVJAdQ0emLjiqn512VsAt2XM/WO9CdcuQl90ETi6R1iKHfG43tJAzxExQdfTul6fSSiC0WnlwEP8BmvYXlmYbeh0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040281)(6060326)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6061324)(6041223); SRVR:MWHPR07MB2846; BCL:0; PCL:0; RULEID:; SRVR:MWHPR07MB2846; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2846; 4:WZv+bfPTSILVPOAK4xEqWhlf9jP+2yrry/7QavhLA43UTsRtf36OhHWj7jH2HclwP7D0k+npiL1z4Wz4v2U1lQhu+J2ks0xu8C/bm9akPtAA2d+nR8gy5breziFVhwJC2VYrBJfxalVKu/MG5AykMymrXePHqnbIRKwol0hSFlDd+FzP6yUfQX1cCzYZBY+UWZoyOkQ5G2GJqRqgML2FtV7e/FpeoYin7HvAukYEyPCaK6K78z4nshe99mwiuc3J+/RVJUPwQ9OdbqUSeVxWQrAMjh/rpqhQvTSYPiXA0K4BCCP7TyEgpR4jrjaY0VOHpRPDBdJFQJLqiNEwHUOYqdh8x+GtkCZJWYo+oUKm1O4Z1ZrABjWqgKwMCmkXmve5eE3ZriHR/JZymQkZUp/TDiZEmEKo69sgvCV/so/iROfkoGZhOmJ/82JCGSPQ3aQAUUVRDQoOvo5MOE/GOIXYPQ== X-Forefront-PRVS: 01304918F3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(106356001)(2351001)(105586002)(7846002)(4326007)(47776003)(305945005)(33646002)(107886002)(5660300001)(7736002)(36756003)(42882006)(6916009)(6666003)(4001430100002)(38730400001)(5003940100001)(110136003)(68736007)(81166006)(81156014)(50986999)(92566002)(101416001)(2906002)(97736004)(42186005)(53416004)(77096005)(189998001)(48376002)(6116002)(50466002)(3846002)(50226002)(69596002)(8676002)(66066001)(15760500001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB2846; H:tns2.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB2846; 23:mnypkMbG886SvXQX6ngnId7EfPHAVQR5xX2X3s5sI?= =?us-ascii?Q?aCvVZyrN5Sjk1y1JuXd1PmEVpkjW2MfdhdPmLjW5UivVxeBIFniXAasfjD2m?= =?us-ascii?Q?KbNa0JcYYPlv5aR2PC6xOVDPOWWLJh3rtrM1tZ5KIbnoShH1bz8/cLejLGCz?= =?us-ascii?Q?huIlmEqHSiflNp3+pRaef6cd8vhDpLGgoloxCte27CKKvGTGZLLE8b+cxGFH?= =?us-ascii?Q?JslutyK0YrAS7eJc7PuoSp9ECeKzxJ7PmrBKotXqzHbIR4uW+fjMcpXhLnwZ?= =?us-ascii?Q?WZYh0NfU4t2X8S/gkKA05jpXCDkK729nOfoTwOSF5x2AdadRmvovXQ0Gdn0x?= =?us-ascii?Q?qOXRQVXwD0xZmuSp/WTup0W5Q2Rr18/f34smUz+Xl1Q06Zwp4w9SRXbml5IG?= =?us-ascii?Q?UT76PKsnLl6Q3J6Kp88G+m7Y1KwalLDGdl+aKBTVZOCLbsDt7hozX3wQovRf?= =?us-ascii?Q?xQ+q3pX6taDwKr4JyH8+A70dY+PPRc0WIs8lGBnH1l0YLbgn2+D15TVBwBjD?= =?us-ascii?Q?+VWVfktI3u5qUWNC0mPl2/nvIhjtjyBGaN7cSA+IrIpjYnfw/jivmN3iHWvG?= =?us-ascii?Q?9fRrTZYOkr1Qm+ucooNNly5atQ3UzwXZLXmMdtcQneIUOsmCaVG7JBR1+bK+?= =?us-ascii?Q?uYQV5R6KUO/XYzP29OjUYBU2tTiRLjJrpptyo0Et0pv6NOnYUZaKrq9alhwf?= =?us-ascii?Q?fkQBO30CX+gVDOTcNi+/aGJMvS00eieZsww0LUGz4WQ9kfXHiyXosn6Bnbra?= =?us-ascii?Q?GXGNTGDCABAQP5sL+HsUwCrSHzY6Sw8rwcFe4cWMaIAvQem4W4KRhb64r0Mo?= =?us-ascii?Q?EWJOW5/bZ0EuVxptDgDrsGWhu5ZBlmXYBvbzYKonB73Q16YFh7YeMvIf46kw?= =?us-ascii?Q?mRzmQORQYTWagF/wN6UCOzq6RODVhkuY0u+4i7VA85XYO/k51WwOSZ1ncFjv?= =?us-ascii?Q?z4LH0edoi38KV79A0dOFRPy1n+bdfynKBdbDBN8JmQ54K9fRRPA+KbuT3xZ4?= =?us-ascii?Q?nyduDzoG649mtJBegh8iley6njzthgkDGbVv/w3XQ1eWyQAU/zcqC++VkrXv?= =?us-ascii?Q?75Ge47ebBRfwDwmDJAhUaK8mIGapL/y22W3iBPFdZyXbz4GSP7HoZtBXpW2u?= =?us-ascii?Q?0g9vdN1apZmN1WmFADZKvipSSWkVg5S?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2846; 6:mlQMqW7h5rCHXCA0AoE7xmzrdc9rWfOU4zrDJ+ATmKWiOBhVnK7U/rC1gWYTyEjFDSdajFIPfC7x4rXlyo2MVm/o5pkIxoh1lEB+t9GHPfFuPbfoMjz3nijsDOHVyDrYPfr1z8VYCnNH1+w1D98kzNbTsdgVCxuQ5vuipQ3LRl0rIXdECXjs4WLMCvRYK8aZWVHDOJ/5J90+jnlBrobuvoHuFZqNFF+8W3JmJb5YvJE4TiHbVULTIDif9Q5qFYZkvrdXa4BYCpCvXpKLvHu2CA1k/NQjLUn5X5UXS6L6ZEDBl/OpsRI/YOOrI0yZL5MZGQOdsqVYPO9ies0Kt+/n7N2j5YlkXL9l8dNiY+0usn4=; 5:f8hCaGJubDUXdS8AhE6XPM/b5DCp83zYEK/0XOP0nsgrgUQXyl9m/e7Q9rOFPsGbOC8FZ9pbZnnjcFJxQnyjB2KKie6amZcooO2IRFVa1U9XNS3phCiUpioUuHtWgyP8ursqD0dS/h0gJBIvMklPjw==; 24:xYTHEz3lkxP049IUeV6A2Wktfwrsf9ZPxHX4m+0Eb60pjzuoUYk6jAP/aEgqYGs6PpVIq/idzsCjps8fJZ3OB1Iz3M2HOm0Of8N3jzlWt5c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2846; 7:ei6xE5SWiMT3yoSVyFPdManxlOvS/nf/EG+oop8jp8a5uDisvImjTQ236TMMMydYWgjk+ws/IkQlf5ab5B3Ix2sfUpunyLQKY/+QtVuY5VIQzQoy3WXDdOr6CB3u/ROdpWGSwCNA+0W9ck8pqln61LTt+57frKeJGDPNopP4XtOAAL4wF/Ma4N6/m7WQ5xS2f8FuiqgSmVYFNNovyRY/tFxrSDs2Ws28x00NIzUU0JRF+VscN5i5OUHDCUU49wEsQaf7gyiAf/RURSSumXXps3onzCXeU3gqv6g584P/Qdws7sqsIzszWJAF+Cm0+DSaoNasfHxQyVaZKBBHUNcQz825I2Z6bBkucwzvHjxN0vI= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2016 12:52:31.5020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB2846 Subject: [dpdk-dev] [PATCH v2] i40e: Fix eth_i40e_dev_init sequence on ThunderX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 12:52:35 -0000 i40e_asq_send_command: rd32 & wr32 under ThunderX gives unpredictable results. To solve this include rte memory barriers Signed-off-by: Satha Rao --- drivers/net/i40e/base/i40e_osdep.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h index 38e7ba5..ffa3160 100644 --- a/drivers/net/i40e/base/i40e_osdep.h +++ b/drivers/net/i40e/base/i40e_osdep.h @@ -158,7 +158,13 @@ do { \ ((volatile uint32_t *)((char *)(a)->hw_addr + (reg))) static inline uint32_t i40e_read_addr(volatile void *addr) { +#if defined(RTE_ARCH_ARM64) + uint32_t val = rte_le_to_cpu_32(I40E_PCI_REG(addr)); + rte_rmb(); + return val; +#else return rte_le_to_cpu_32(I40E_PCI_REG(addr)); +#endif } #define I40E_PCI_REG_WRITE(reg, value) \ do { I40E_PCI_REG((reg)) = rte_cpu_to_le_32(value); } while (0) @@ -171,8 +177,16 @@ static inline uint32_t i40e_read_addr(volatile void *addr) I40E_PCI_REG_WRITE(I40E_PCI_REG_ADDR((hw), (reg)), (value)) #define rd32(a, reg) i40e_read_addr(I40E_PCI_REG_ADDR((a), (reg))) +#if defined(RTE_ARCH_ARM64) +#define wr32(a, reg, value) \ + do { \ + I40E_PCI_REG_WRITE(I40E_PCI_REG_ADDR((a), (reg)), (value)); \ + rte_wmb(); \ + } while (0) +#else #define wr32(a, reg, value) \ I40E_PCI_REG_WRITE(I40E_PCI_REG_ADDR((a), (reg)), (value)) +#endif #define flush(a) i40e_read_addr(I40E_PCI_REG_ADDR((a), (I40E_GLGEN_STAT))) #define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0])) -- 2.7.4