From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library
Date: Sat, 14 Jun 2014 09:55:43 +0200 [thread overview]
Message-ID: <1479982.fmX6nuUaYb@xps13> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA36227@IRSMSX103.ger.corp.intel.com>
2014-06-14 00:07, Richardson, Bruce:
> From: Thomas Monjalon
> > I've made the code style changes, move some configuration lines and added
> > to BSD build (not tested).
> >
> I'd be a bit wary about adding it to the BSD build. I'm only running BSD in
> a VM here, but there GCC fails to recognise the processor supports SSE4
> instruction sets when using "-march=native", and so fails to compile the
> vector code - at least the vectorized PMD functions. That's why I've
> explicitly disabled those in the latest version of the vector PMD patch,
> and I would suggest doing the same for the ACL code for now.
Actually, the configuration option didn't exist for BSD so I added it.
It's better to explicitly disable it with an explanation in git history.
Thanks
--
Thomas
prev parent reply other threads:[~2014-06-14 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 11:26 Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 1/5] Add ACL library (librte_acl) into DPDK Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 2/5] acl: update UT to reflect latest changes in the librte_acl Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 3/5] acl: New test-acl application Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 4/5] acl: New sample l3fwd-acl Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 5/5] acl: add doxygen configuration and start page Konstantin Ananyev
2014-06-13 11:56 ` [dpdk-dev] [PATCHv3 0/5] ACL library Thomas Monjalon
2014-06-13 12:02 ` Ananyev, Konstantin
2014-06-13 23:38 ` Thomas Monjalon
2014-06-14 0:07 ` Richardson, Bruce
2014-06-14 7:55 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479982.fmX6nuUaYb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).