From: Harish Patil <harish.patil@qlogic.com>
To: <dev@dpdk.org>
Cc: <Dept-EngDPDKDev@qlogic.com>, Harish Patil <harish.patil@qlogic.com>
Subject: [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF
Date: Fri, 2 Dec 2016 18:43:59 -0800 [thread overview]
Message-ID: <1480733039-13046-7-git-send-email-harish.patil@qlogic.com> (raw)
In-Reply-To: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com>
Fix to adverstise max_rx_queues by taking into account the number
of PF connections instead of returning max_queues supported by the
HW.
Fixes: 2ea6f76a ("qede: add core driver")
Signed-off-by: Harish Patil <harish.patil@qlogic.com>
---
drivers/net/qede/qede_ethdev.c | 13 ++++++++++---
drivers/net/qede/qede_ethdev.h | 3 +++
drivers/net/qede/qede_main.c | 5 -----
3 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 10abb8b..9c2a5ea 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -973,8 +973,15 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
dev_info->max_rx_pktlen = (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN;
dev_info->rx_desc_lim = qede_rx_desc_lim;
dev_info->tx_desc_lim = qede_tx_desc_lim;
- dev_info->max_rx_queues = (uint16_t)QEDE_MAX_RSS_CNT(qdev);
+
+ if (IS_PF(edev))
+ dev_info->max_rx_queues = (uint16_t)RTE_MIN(
+ QEDE_MAX_RSS_CNT(qdev), QEDE_PF_NUM_CONNS / 2);
+ else
+ dev_info->max_rx_queues = (uint16_t)RTE_MIN(
+ QEDE_MAX_RSS_CNT(qdev), ECORE_MAX_VF_CHAINS_PER_PF);
dev_info->max_tx_queues = dev_info->max_rx_queues;
+
dev_info->max_mac_addrs = qdev->dev_info.num_mac_addrs;
dev_info->max_vfs = 0;
dev_info->reta_size = ECORE_RSS_IND_TABLE_SIZE;
@@ -2015,9 +2022,9 @@ int qede_dev_filter_ctrl(struct rte_eth_dev *eth_dev,
static void qede_update_pf_params(struct ecore_dev *edev)
{
struct ecore_pf_params pf_params;
- /* 32 rx + 32 tx */
+
memset(&pf_params, 0, sizeof(struct ecore_pf_params));
- pf_params.eth_pf_params.num_cons = 64;
+ pf_params.eth_pf_params.num_cons = QEDE_PF_NUM_CONNS;
qed_ops->common->update_pf_params(edev, &pf_params);
}
diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h
index bd85ba3..95e06ef 100644
--- a/drivers/net/qede/qede_ethdev.h
+++ b/drivers/net/qede/qede_ethdev.h
@@ -115,6 +115,9 @@
extern char fw_file[];
+/* Number of PF connections - 32 RX + 32 TX */
+#define QEDE_PF_NUM_CONNS (64)
+
/* Port/function states */
enum qede_dev_state {
QEDE_DEV_INIT, /* Init the chip and Slowpath */
diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index b7202c8..2c88329 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -399,11 +399,6 @@ static int qed_slowpath_start(struct ecore_dev *edev,
if (edev->num_hwfns > 1) {
ecore_vf_get_num_rxqs(&edev->hwfns[1], &queues);
info->num_queues += queues;
- /* Restrict 100G VF to advertise 16 queues till the
- * required support is available to go beyond 16.
- */
- info->num_queues = RTE_MIN(info->num_queues,
- ECORE_MAX_VF_CHAINS_PER_PF);
}
ecore_vf_get_num_vlan_filters(&edev->hwfns[0],
--
1.8.3.1
next prev parent reply other threads:[~2016-12-03 2:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 2:43 [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code Harish Patil
2016-12-08 16:45 ` Ferruh Yigit
2016-12-12 17:36 ` Harish Patil
2016-12-12 17:53 ` Ferruh Yigit
2016-12-20 23:12 ` Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 4/7] net/qede: add fastpath " Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-03 2:43 ` [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0 Harish Patil
2016-12-08 16:45 ` Ferruh Yigit
2016-12-12 17:47 ` Harish Patil
2016-12-12 18:13 ` Ferruh Yigit
2016-12-19 13:38 ` Thomas Monjalon
2016-12-20 23:15 ` Harish Patil
2016-12-03 2:43 ` Harish Patil [this message]
2016-12-08 16:45 ` [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF Ferruh Yigit
2016-12-12 19:29 ` Harish Patil
2016-12-12 20:10 ` Ferruh Yigit
2016-12-20 23:16 ` Harish Patil
2016-12-08 16:44 ` [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-12 17:15 ` Harish Patil
2016-12-12 17:50 ` Ferruh Yigit
2016-12-20 22:02 ` Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 " Harish Patil
2016-12-23 15:14 ` Ferruh Yigit
2016-12-23 15:25 ` Ferruh Yigit
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 2/7] net/qede: fix filtering code Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 4/7] net/qede: add fastpath " Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 6/7] net/qede: fix reporting of SR-IOV PF driver as disabled Harish Patil
2016-12-23 0:48 ` [dpdk-dev] [PATCH v2 7/7] net/qede: restrict maximum queues for PF/VF Harish Patil
2016-12-08 16:48 ` [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-20 23:29 ` Mody, Rasesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480733039-13046-7-git-send-email-harish.patil@qlogic.com \
--to=harish.patil@qlogic.com \
--cc=Dept-EngDPDKDev@qlogic.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).