From: Rasesh Mody <Rasesh.Mody@cavium.com>
To: <dev@dpdk.org>
Cc: <Dept-EngDPDKDev@cavium.com>, Rasesh Mody <Rasesh.Mody@cavium.com>
Subject: [dpdk-dev] [PATCH 7/8] net/qede/base: fix to handle acquire request from VF
Date: Fri, 2 Dec 2016 22:35:08 -0800 [thread overview]
Message-ID: <1480746909-25686-7-git-send-email-Rasesh.Mody@cavium.com> (raw)
In-Reply-To: <1480746909-25686-1-git-send-email-Rasesh.Mody@cavium.com>
Add a check and fail the VF's probe request if VF is already in
VF_ACQUIRED state.
Fixes: 22d07d93 ("net/qede/base: update")
Signed-off-by: Rasesh Mody <Rasesh.Mody@cavium.com>
---
drivers/net/qede/base/ecore_sriov.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c
index 12552966..c2fbee87 100644
--- a/drivers/net/qede/base/ecore_sriov.c
+++ b/drivers/net/qede/base/ecore_sriov.c
@@ -1459,6 +1459,18 @@ static void ecore_iov_vf_mbx_acquire(struct ecore_hwfn *p_hwfn,
pfdev_info->major_fp_hsi = ETH_HSI_VER_MAJOR;
pfdev_info->minor_fp_hsi = ETH_HSI_VER_MINOR;
+ /* TODO - not doing anything is bad since we'll assert, but this isn't
+ * necessarily the right behavior - perhaps we should have allowed some
+ * versatility here.
+ */
+ if (vf->state != VF_FREE &&
+ vf->state != VF_STOPPED) {
+ DP_VERBOSE(p_hwfn, ECORE_MSG_IOV,
+ "VF[%d] sent ACQUIRE but is already in state %d - fail request\n",
+ vf->abs_vf_id, vf->state);
+ goto out;
+ }
+
/* Validate FW compatibility */
if (req->vfdev_info.eth_fp_hsi_major != ETH_HSI_VER_MAJOR) {
if (req->vfdev_info.capabilities &
--
2.11.0.rc1
next prev parent reply other threads:[~2016-12-03 6:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 6:35 [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 2/8] net/qede/base: fix sriov printouts Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 3/8] net/qede/base: fix multiple acquisition requests by VF Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 4/8] net/qede/base: fix error return code in resc alloc Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 5/8] net/qede/base: fix mutex in freeing context manager Rasesh Mody
2016-12-03 6:35 ` [dpdk-dev] [PATCH 6/8] net/qede/base: fix Rx queue access by malicious VFs Rasesh Mody
2016-12-03 6:35 ` Rasesh Mody [this message]
2016-12-03 6:35 ` [dpdk-dev] [PATCH 8/8] net/qede/base: fix to check FW override after rejection Rasesh Mody
2016-12-09 13:35 ` [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info Ferruh Yigit
2016-12-20 23:25 ` Mody, Rasesh
2016-12-23 0:49 ` [dpdk-dev] [PATCH v2 " Rasesh Mody
2016-12-23 15:26 ` Ferruh Yigit
2016-12-23 0:49 ` [dpdk-dev] [PATCH v2 2/8] net/qede/base: fix sriov printouts Rasesh Mody
2016-12-23 0:49 ` [dpdk-dev] [PATCH v2 3/8] net/qede/base: fix multiple acquisition requests by VF Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 4/8] net/qede/base: fix error return code in resc alloc Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 5/8] net/qede/base: fix mutex in freeing context manager Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 6/8] net/qede/base: fix Rx queue access by malicious VFs Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 7/8] net/qede/base: fix to handle acquire request from VF Rasesh Mody
2016-12-23 0:50 ` [dpdk-dev] [PATCH v2 8/8] net/qede/base: fix VF over legacy PF Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480746909-25686-7-git-send-email-Rasesh.Mody@cavium.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).