DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4
Date: Fri, 27 Nov 2015 09:59:38 +0100	[thread overview]
Message-ID: <14808329.F48z9c4v47@xps13> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E6028621B8CCF5@SHSMSX101.ccr.corp.intel.com>

2015-11-27 02:26, Qiu, Michael:
> On 2015/11/27 5:29, Thomas Monjalon wrote:
> > 2015-11-26 18:49, Michael Qiu:
> >> gcc 4.3.4 does not include "immintrin.h", and will post below error:
> >>     lib/librte_sched/rte_sched.c:56:23: error:
> >>     immintrin.h: No such file or directory
> >>
> >> To avoid this issue, a gcc version check is need and a flag to indicate
> >> vector ablility.
> > [...]
> >> +#if (defined(__ICC) || (__GNUC__ == 4 &&  __GNUC_MINOR__ < 4))
> >> +
> >> +#if defined(__AVX__)
> >>  #include <immintrin.h>
> >> +#define SCHED_VECTOR_ENABLE
> >> +#endif
> >> +
> >> +#else
> >> +
> >> +#include <x86intrin.h>
> >> +#define SCHED_VECTOR_ENABLE
> >> +
> >> +#endif
> > This kind of complication is managed by EAL.
> > I think we should include rte_vect.h.
> 
> As I know here it needs a flag to identify whether the platform support
> AVX, if not it will not use it, so I don't know if we could only simply
> include rte_vect.h?

It's not exclusive.
You can include rte_vect.h and check AVX to define SCHED_VECTOR_ENABLE.

  reply	other threads:[~2015-11-27  9:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 10:49 Michael Qiu
2015-11-26 21:28 ` Thomas Monjalon
2015-11-27  2:26   ` Qiu, Michael
2015-11-27  8:59     ` Thomas Monjalon [this message]
2015-11-27 11:53       ` Qiu, Michael
2015-11-27 12:34         ` Ananyev, Konstantin
2015-11-27 14:01           ` Qiu, Michael
2015-11-27 14:09             ` Ananyev, Konstantin
2015-11-27 15:22               ` Qiu, Michael
2015-11-27 16:21                 ` Ananyev, Konstantin
2015-12-02  2:09 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2015-12-02  2:18   ` Thomas Monjalon
2015-12-02  2:29     ` Qiu, Michael
2015-12-02  2:39 ` [dpdk-dev] [PATCH v3] " Michael Qiu
2015-12-02 22:10   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14808329.F48z9c4v47@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).