From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id E07AE9A9B for ; Wed, 25 Feb 2015 14:40:09 +0100 (CET) Received: by mail-wi0-f178.google.com with SMTP id em10so5075854wid.5 for ; Wed, 25 Feb 2015 05:40:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=HTWsfubrL588xVlGpRbmke+Yju6U5ao1i8b1Sg2Kg1A=; b=jARAl/JV7B3hhoMc0qckjkYCD/Bl/DdFg9sIA1Uz1SSfYiR2/kL/1eOqq122/BuHIx h0ncsZFwfknKkqYe8phkp9CtjXNCPMFTgyW6S6bE4MZhi330qs/cRjw6GOZt1Ll72G4O LpMZX9Mqh0g87MtmicSaL/YMlzKfuKpLhUhJTq/B/IoUYHKcbwzx8ag7mOlOj16ZK14h DxUAIYvRZqu0VzFxBZB0uwxU4tTHJpmtjb32OSjEXxL9Uyw9gqLxv3IEAD+kRkcsRUd6 xXTBfj+jqifsRwr+E6O2XcfoRoXzGBBxYsUTNTc8UJbCqRbc4BO3ngromsFWxU6Ouk1Y WVSg== X-Gm-Message-State: ALoCoQlVccAnf0FChdTVlXOcexI0vtdQE2LYWIJJ60HteYNekjrHzhMS6A3V9JzNYmABa786vGeM X-Received: by 10.180.208.20 with SMTP id ma20mr39598954wic.22.1424871608473; Wed, 25 Feb 2015 05:40:08 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q10sm64906223wjr.41.2015.02.25.05.40.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2015 05:40:07 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Wed, 25 Feb 2015 14:39:33 +0100 Message-ID: <1481785.S6qqJ57RgF@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150225123053.GA31224@hmsreliant.think-freely.org> References: <1424835589-18122-1-git-send-email-cunming.liang@intel.com> <20150225123053.GA31224@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2015 13:40:10 -0000 2015-02-25 07:30, Neil Horman: > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote: > > These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y. > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map. > > Thanks for the notification from Tetsuya Mukawa . > > > > Cunming Liang (2): > > eal/linux: fix symbol missing in version map > > eal/bsd: fix symbol missing in version map > > > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++ > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ > > 2 files changed, 4 insertions(+) > > > > NAK > > This is the wrong way to fix this problem. Exporting global variables is > never a good solution when it can be helped. Instead, rte_socket id should be > made a non inline function and exported. Then the definition of > per_lcore_socket_id can be made private, protecting it from type changes. Neil, I applied the patches to fix compilation on HEAD. In case your comment makes sense, a cleanup would be appreciated. Thanks