From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maryam Tahhan <maryam.tahhan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in stats structs
Date: Fri, 17 Jul 2015 01:04:17 +0200 [thread overview]
Message-ID: <14827227.16LvSo2xtm@xps13> (raw)
In-Reply-To: <1436965894-130019-5-git-send-email-maryam.tahhan@intel.com>
2015-07-15 14:11, Maryam Tahhan:
> Remove non generic stats in rte_stats_strings and mark the relevant
> fields in struct rte_eth_stats as deprecated.
>
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> - uint64_t imissed; /**< Total of RX missed packets (e.g full FIFO). */
> - uint64_t ibadcrc; /**< Total of RX packets with CRC error. */
> - uint64_t ibadlen; /**< Total of RX packets with bad length. */
> + /**< Deprecated; Total of RX missed packets (e.g full FIFO). */
> + uint64_t imissed;
> + /**< Deprecated; Total of RX packets with CRC error. */
> + uint64_t ibadcrc;
> + /**< Deprecated; Total of RX packets with bad length. */
> + uint64_t ibadlen;
The /**< style comments must be put *after* the field.
next prev parent reply other threads:[~2015-07-16 23:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 13:11 [dpdk-dev] [PATCH v6 0/9] Expose IXGBE extended stats to DPDK apps Maryam Tahhan
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 1/9] ixgbe: move stats register reads to a new function Maryam Tahhan
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 2/9] ixgbe: add functions to get and reset xstats Maryam Tahhan
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 3/9] ethdev: expose extended error stats Maryam Tahhan
2015-07-16 23:02 ` Thomas Monjalon
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in stats structs Maryam Tahhan
2015-07-16 23:04 ` Thomas Monjalon [this message]
2015-08-17 14:53 ` Olivier MATZ
2015-08-19 12:53 ` Tahhan, Maryam
2015-08-19 13:44 ` Olivier MATZ
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 5/9] ixgbe: add NIC specific stats removed from ethdev Maryam Tahhan
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 6/9] ixgbe: return more errors in ierrors Maryam Tahhan
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 7/9] app: remove dump_cfg Maryam Tahhan
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 8/9] app: add a new app proc_info Maryam Tahhan
2015-07-15 13:11 ` [dpdk-dev] [PATCH v6 9/9] doc: Add documentation for proc_info Maryam Tahhan
2015-07-16 7:54 ` [dpdk-dev] [PATCH v6 0/9] Expose IXGBE extended stats to DPDK apps Olivier MATZ
2015-07-17 0:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14827227.16LvSo2xtm@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).