From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id F3B105A51
 for <dev@dpdk.org>; Fri, 17 Jul 2015 01:05:30 +0200 (CEST)
Received: by wgav7 with SMTP id v7so4028290wga.2
 for <dev@dpdk.org>; Thu, 16 Jul 2015 16:05:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=sfwzbvCia/K8/Tf4Svak3+0RdiBo6AnKB+rAu5mD1iI=;
 b=cMZpiji4BLUQVva0bZy+5iY8PvccRYQhellMkj6QVTT9q/g+VCezSFYKMdkbQXvN6J
 rgFECQuVGXRA5F3e8W6R7wF5oWM2swYugcUVCkQ8POdMFja3JGJqpShW9XIg64Ubjlq0
 rnhvVfgUjP1z22KcGoeKzOiUh/geSmUdz+hyQumBILt5WPWFpOZVVYKgUsLAmiCUGma2
 5v8aFXVrTIl2xyxVu0a4OrZ6bpM46TGJ+jo41j92ocoGd46svAoK4ugVAMkP/SwxDsb0
 l2i3TgO9atma6h3TPZnoO5Nqm0GZgr4Dd5lAj9TWka8lWMQqbbZeWfbw8GPyCvBaHn+9
 aIQQ==
X-Gm-Message-State: ALoCoQnZ3eMaBJfNurMCS5Z35TgogpsEKtxrYbXxMfCBXIs/V4+LEh9Xs2p4XavhhQwICYAqSQiG
X-Received: by 10.180.77.40 with SMTP id p8mr9629986wiw.29.1437087930901;
 Thu, 16 Jul 2015 16:05:30 -0700 (PDT)
Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net.
 [82.235.116.147])
 by smtp.gmail.com with ESMTPSA id ec19sm5963403wic.0.2015.07.16.16.05.28
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 16 Jul 2015 16:05:29 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maryam Tahhan <maryam.tahhan@intel.com>
Date: Fri, 17 Jul 2015 01:04:17 +0200
Message-ID: <14827227.16LvSo2xtm@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1436965894-130019-5-git-send-email-maryam.tahhan@intel.com>
References: <1436965894-130019-1-git-send-email-maryam.tahhan@intel.com>
 <1436965894-130019-5-git-send-email-maryam.tahhan@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in
	stats structs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jul 2015 23:05:31 -0000

2015-07-15 14:11, Maryam Tahhan:
> Remove non generic stats in rte_stats_strings and mark the relevant
> fields in struct rte_eth_stats as deprecated.
> 
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>

> -	uint64_t imissed;   /**< Total of RX missed packets (e.g full FIFO). */
> -	uint64_t ibadcrc;   /**< Total of RX packets with CRC error. */
> -	uint64_t ibadlen;   /**< Total of RX packets with bad length. */
> +	/**< Deprecated; Total of RX missed packets (e.g full FIFO). */
> +	uint64_t imissed;
> +	/**< Deprecated; Total of RX packets with CRC error. */
> +	uint64_t ibadcrc;
> +	/**< Deprecated; Total of RX packets with bad length. */
> +	uint64_t ibadlen;

The /**< style comments must be put *after* the field.