DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [RFC 01/23] eal: CPU init will no longer panic
Date: Fri, 30 Dec 2016 10:25:58 -0500	[thread overview]
Message-ID: <1483111580-5397-2-git-send-email-aconole@redhat.com> (raw)
In-Reply-To: <1483111580-5397-1-git-send-email-aconole@redhat.com>

After this change, the EAL CPU NUMA node resolution step can no longer
emit an rte_panic.  This aligns with the code in rte_eal_init, which
expects failures to return an error code.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 lib/librte_eal/common/eal_common_lcore.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
index 2cd4132..84fa0cb 100644
--- a/lib/librte_eal/common/eal_common_lcore.c
+++ b/lib/librte_eal/common/eal_common_lcore.c
@@ -83,16 +83,17 @@ rte_eal_cpu_init(void)
 		config->lcore_role[lcore_id] = ROLE_RTE;
 		lcore_config[lcore_id].core_id = eal_cpu_core_id(lcore_id);
 		lcore_config[lcore_id].socket_id = eal_cpu_socket_id(lcore_id);
-		if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES)
+		if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES) {
 #ifdef RTE_EAL_ALLOW_INV_SOCKET_ID
 			lcore_config[lcore_id].socket_id = 0;
 #else
-			rte_panic("Socket ID (%u) is greater than "
+			RTE_LOG(ERR, EAL, "Socket ID (%u) is greater than "
 				"RTE_MAX_NUMA_NODES (%d)\n",
 				lcore_config[lcore_id].socket_id,
 				RTE_MAX_NUMA_NODES);
+			return -1;
 #endif
-
+		}
 		RTE_LOG(DEBUG, EAL, "Detected lcore %u as "
 				"core %u on socket %u\n",
 				lcore_id, lcore_config[lcore_id].core_id,
-- 
2.7.4

  reply	other threads:[~2016-12-30 15:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 15:25 [dpdk-dev] [RFC 00/23] Refactor eal_init to remove panic() calls Aaron Conole
2016-12-30 15:25 ` Aaron Conole [this message]
2016-12-30 15:25 ` [dpdk-dev] [RFC 02/23] eal: return error instead of panic for cpu init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 03/23] eal: No panic on hugepages info init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 04/23] eal: do not panic on failed hugepage query Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 05/23] eal: failure to parse args returns error Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 06/23] eal-common: introduce a way to query cpu support Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 07/23] eal: Signal error when CPU isn't supported Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 08/23] eal: do not panic on memzone initialization fails Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 09/23] eal: set errno when exiting for already called Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 10/23] eal: Do not panic on log failures Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 11/23] eal: Do not panic on pci-probe Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 12/23] eal: do not panic on vfio failure Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 13/23] eal: do not panic on memory init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 14/23] eal: do not panic on tailq init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 15/23] eal: do not panic on alarm init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 16/23] eal: convert timer_init not to call panic Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 17/23] eal: change the private pipe call to reflect errno Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 18/23] eal: Do not panic on interrupt thread init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 19/23] eal: do not error if plugins fail to init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 20/23] eal_pci: Continue probing even on failures Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 21/23] eal: do not panic on failed PCI probe Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 22/23] eal_common_dev: continue initializing vdevs Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 23/23] eal: do not panic (or abort) if vdev init fails Aaron Conole
2017-01-02 14:22 ` [dpdk-dev] [RFC 00/23] Refactor eal_init to remove panic() calls Thomas Monjalon
2017-01-03 16:06   ` Aaron Conole
2017-01-25 21:33   ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483111580-5397-2-git-send-email-aconole@redhat.com \
    --to=aconole@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).