From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [RFC 20/23] eal_pci: Continue probing even on failures
Date: Fri, 30 Dec 2016 10:26:17 -0500 [thread overview]
Message-ID: <1483111580-5397-21-git-send-email-aconole@redhat.com> (raw)
In-Reply-To: <1483111580-5397-1-git-send-email-aconole@redhat.com>
Some devices may be inaccessible for a variety of reasons, or the
PCI-bus may be unavailable causing the whole thing to fail. Still,
better to continue attempts at probes.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
lib/librte_eal/common/eal_common_pci.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 33485bc..ca5c63e 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -69,6 +69,7 @@
#include <sys/queue.h>
#include <sys/mman.h>
+#include <rte_errno.h>
#include <rte_interrupts.h>
#include <rte_log.h>
#include <rte_pci.h>
@@ -413,6 +414,7 @@ rte_eal_pci_probe(void)
struct rte_pci_device *dev = NULL;
struct rte_devargs *devargs;
int probe_all = 0;
+ int ret_1 = 0;
int ret = 0;
if (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) == 0)
@@ -427,17 +429,20 @@ rte_eal_pci_probe(void)
/* probe all or only whitelisted devices */
if (probe_all)
- ret = pci_probe_all_drivers(dev);
+ ret_1 = pci_probe_all_drivers(dev);
else if (devargs != NULL &&
devargs->type == RTE_DEVTYPE_WHITELISTED_PCI)
- ret = pci_probe_all_drivers(dev);
- if (ret < 0)
- rte_exit(EXIT_FAILURE, "Requested device " PCI_PRI_FMT
+ ret_1 = pci_probe_all_drivers(dev);
+ if (ret_1 < 0) {
+ RTE_LOG (ERR, EAL, "Requested device " PCI_PRI_FMT
" cannot be used\n", dev->addr.domain, dev->addr.bus,
dev->addr.devid, dev->addr.function);
+ rte_errno = errno;
+ ret = 1;
+ }
}
- return 0;
+ return -ret;
}
/* dump one device */
--
2.7.4
next prev parent reply other threads:[~2016-12-30 15:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 15:25 [dpdk-dev] [RFC 00/23] Refactor eal_init to remove panic() calls Aaron Conole
2016-12-30 15:25 ` [dpdk-dev] [RFC 01/23] eal: CPU init will no longer panic Aaron Conole
2016-12-30 15:25 ` [dpdk-dev] [RFC 02/23] eal: return error instead of panic for cpu init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 03/23] eal: No panic on hugepages info init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 04/23] eal: do not panic on failed hugepage query Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 05/23] eal: failure to parse args returns error Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 06/23] eal-common: introduce a way to query cpu support Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 07/23] eal: Signal error when CPU isn't supported Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 08/23] eal: do not panic on memzone initialization fails Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 09/23] eal: set errno when exiting for already called Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 10/23] eal: Do not panic on log failures Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 11/23] eal: Do not panic on pci-probe Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 12/23] eal: do not panic on vfio failure Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 13/23] eal: do not panic on memory init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 14/23] eal: do not panic on tailq init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 15/23] eal: do not panic on alarm init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 16/23] eal: convert timer_init not to call panic Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 17/23] eal: change the private pipe call to reflect errno Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 18/23] eal: Do not panic on interrupt thread init Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 19/23] eal: do not error if plugins fail to init Aaron Conole
2016-12-30 15:26 ` Aaron Conole [this message]
2016-12-30 15:26 ` [dpdk-dev] [RFC 21/23] eal: do not panic on failed PCI probe Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 22/23] eal_common_dev: continue initializing vdevs Aaron Conole
2016-12-30 15:26 ` [dpdk-dev] [RFC 23/23] eal: do not panic (or abort) if vdev init fails Aaron Conole
2017-01-02 14:22 ` [dpdk-dev] [RFC 00/23] Refactor eal_init to remove panic() calls Thomas Monjalon
2017-01-03 16:06 ` Aaron Conole
2017-01-25 21:33 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483111580-5397-21-git-send-email-aconole@redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).