From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A1BB41C30; Tue, 7 Feb 2023 15:58:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE5E640E6E; Tue, 7 Feb 2023 15:58:56 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id F26544021F for ; Tue, 7 Feb 2023 15:58:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 502825C032C; Tue, 7 Feb 2023 09:58:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 07 Feb 2023 09:58:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675781934; x= 1675868334; bh=fKCU7P5V2Bk2cAxMAeyE0sC5N1LfQJmBjWzs7KMJKc0=; b=Z of4nhm49mZpvjjcgDxGIcL+rZiAZ4mxqX4QoFFnGCWxufBTdIIEdvIxzYbPH4Ccw 8iND/Tqdcg5R84tLbttyIcQicK1ebiSucyY7PWYcSaqGgPivOpiuXtIchkk376tO YE92Re7qkwlq6moVXcaSW9JZvol93/gho+DA5pZ9xWNa8AH9sQf0HyH0Odmc4e2V sQXrh9j2Eja3EIP51Bu6GxnHLVqCsHR9zuAP3wxqsA69uCSkERBYAZg30RNkie7p cQAhbVUfnLVFI3YK+6Bwwm2kEr8zowzsNpFaqs+hzjgU4UMVgRh8Hpw6/mqVU2X2 /zPDCAX9hktkxRzAqcRTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675781934; x= 1675868334; bh=fKCU7P5V2Bk2cAxMAeyE0sC5N1LfQJmBjWzs7KMJKc0=; b=o 8C++NJd/+XcyC1FPngZbcKOYoIP38/SYEXcAkSN42aVBbkpgEXvS+ugkJ4+5kYP0 XB5fwNy+MtU4syZBWz/9zLlXJgqZWwAuJ2TarxUCto+gCcQFR9EjAtqzNX2eV1r+ h1i1sZibq6v/6ScNFj53T86RehdQLxJtcQtyZIBC54UTws8ax3UIkQzmgA5nkmyY Sk4e8utoAVz3grNh7bad3WaexFnPDJfnPmSDcfu2TQk0vFWia1vC2n6kdX3Qj9FK Xpd22gecpGfORL45MYXvAkt0/KvOCg+V1EUnNvRMPVRIwzOrtAisfH4lLosgVke9 xQsTCFBmwHAVCOxSJ1sXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegkedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 09:58:52 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, David Marchand , dev@dpdk.org, orika@nvidia.com, andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, ajit.khaparde@broadcom.com Subject: Re: [PATCH v7 0/7] start cleanup of rte_flow_item_* Date: Tue, 07 Feb 2023 15:58:51 +0100 Message-ID: <14831852.JCcGWNJJiE@thomas> In-Reply-To: <20230203164854.602595-1-ferruh.yigit@amd.com> References: <20221025214410.715864-1-thomas@monjalon.net> <20230203164854.602595-1-ferruh.yigit@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/02/2023 17:48, Ferruh Yigit: > There was a plan to have structures from lib/net/ at the beginning > of corresponding flow item structures. > Unfortunately this plan has not been followed up so far. > This series is a step to make the most used items, > compliant with the inheritance design explained above. > The old API is kept in anonymous union for compatibility, > but the code in drivers and apps is updated to use the new API. This series looks good, let's merge. It is only a first step. We will need to continue using more lib/net/ structures in flow offloads. A question to answer later after more thoughts, what is the timeframe to remove old fields? or do we prefer keeping old flow item fields forever?